Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce setting section ids #2923

Merged
merged 2 commits into from
Aug 4, 2022
Merged

Conversation

nickvergessen
Copy link
Contributor

Fix #2917

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen added enhancement New feature or request 3. to review Waiting for reviews feature: settings Related to the settings component breaking PR that requires a new major version labels Aug 3, 2022
@nickvergessen nickvergessen added this to the 6.0.0 milestone Aug 3, 2022
Co-authored-by: Pytal <24800714+Pytal@users.noreply.github.com>
Signed-off-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com>
@nickvergessen nickvergessen merged commit bd275f1 into master Aug 4, 2022
@nickvergessen nickvergessen deleted the breaking/2917/enforce-settings-id branch August 4, 2022 10:54
@juliushaertl juliushaertl mentioned this pull request Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews breaking PR that requires a new major version enhancement New feature or request feature: settings Related to the settings component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not allow empty section id in 6.0+
3 participants