Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ProgressBar): Fix progress rounded corners #3613

Merged
merged 2 commits into from
Jan 5, 2023
Merged

fix(ProgressBar): Fix progress rounded corners #3613

merged 2 commits into from
Jan 5, 2023

Conversation

skjnldsv
Copy link
Contributor

@skjnldsv skjnldsv commented Jan 4, 2023 •
edited
Loading

This is very subtle, check the gif below where I toggle the overflow rule on and off

Peek 04-01-2023 18-52

EDIT: Also fixed the background variable

Before After
image image

@skjnldsv skjnldsv added bug Something isn't working 3. to review Waiting for reviews labels Jan 4, 2023
@skjnldsv skjnldsv self-assigned this Jan 4, 2023
@skjnldsv
fix(ProgressBar): Fix progress rounded corners
20f45a0 
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
@skjnldsv
fix(ProgressBar): Fix progress background
a6d16ef 
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
@skjnldsv skjnldsv requested a review from artonge January 4, 2023 18:05
@skjnldsv skjnldsv mentioned this pull request Jan 4, 2023
Merged
4 tasks
@skjnldsv skjnldsv requested a review from szaimen January 4, 2023 18:10
szaimen
szaimen approved these changes Jan 4, 2023
View reviewed changes
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but didnt test

@szaimen szaimen added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jan 4, 2023
@PVince81 PVince81 merged commit 438cf17 into master Jan 5, 2023
@PVince81 PVince81 deleted the fix/progress branch January 5, 2023 07:59
This was referenced Jan 11, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artonge artonge artonge approved these changes

@szaimen szaimen szaimen approved these changes

@PVince81 PVince81 Awaiting requested review from PVince81

@raimund-schluessler raimund-schluessler Awaiting requested review from raimund-schluessler

@marcoambrosini marcoambrosini Awaiting requested review from marcoambrosini

Assignees

@skjnldsv skjnldsv

Labels
4. to release Ready to be released and/or waiting for tests to finish bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@skjnldsv @artonge @szaimen @PVince81