Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(files): Quota in navigation #36002

Merged
merged 1 commit into from
Jan 18, 2023
Merged

feat(files): Quota in navigation #36002

merged 1 commit into from
Jan 18, 2023

Conversation

skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Jan 4, 2023 •
edited
Loading

Followup #35772

Unlimited With quota
1 2
Warning >80% Full
3 4

Feat

  • Click refreshes the quota
  • Auto-refresh in background
  • Auto-refresh from global files event (deletion, upload, update)
  • Testing

Associated fixes

@skjnldsv skjnldsv self-assigned this Jan 4, 2023
skjnldsv
skjnldsv commented Jan 11, 2023
View reviewed changes
package.json Outdated Show resolved Hide resolved
@skjnldsv skjnldsv force-pushed the feat/files2vue-quota branch 4 times, most recently from 1c1587e to 2eb8ef9 Compare January 12, 2023 11:19
@skjnldsv skjnldsv marked this pull request as ready for review January 12, 2023 11:30
@skjnldsv skjnldsv requested review from a team, artonge, Pytal and szaimen and removed request for a team January 12, 2023 11:30
@skjnldsv skjnldsv added enhancement 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jan 12, 2023
@skjnldsv skjnldsv added this to the Nextcloud 26 milestone Jan 12, 2023
@skjnldsv skjnldsv requested a review from artonge January 12, 2023 12:59
@skjnldsv skjnldsv requested a review from come-nc January 12, 2023 16:27
@skjnldsv
Copy link
Member Author

Failures unrelated

come-nc
come-nc approved these changes Jan 16, 2023
View reviewed changes
Copy link
Contributor

@come-nc come-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed PHP only, fine apart from nitpick and an identation weirdness in the test.

apps/files/appinfo/routes.php Show resolved Hide resolved
apps/files/tests/Controller/ViewControllerTest.php Outdated Show resolved Hide resolved
lib/private/legacy/OC_Helper.php Outdated Show resolved Hide resolved
@skjnldsv
feat(files): Quota in navigation
b9906fb 
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jan 17, 2023
@skjnldsv skjnldsv merged commit 1a0f9b5 into master Jan 18, 2023
@skjnldsv skjnldsv deleted the feat/files2vue-quota branch January 18, 2023 07:05
@nickvergessen nickvergessen mentioned this pull request Apr 5, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artonge artonge artonge approved these changes

@come-nc come-nc come-nc approved these changes

@Pytal Pytal Awaiting requested review from Pytal Pytal was automatically assigned from nextcloud/server-frontend

@szaimen szaimen Awaiting requested review from szaimen szaimen was automatically assigned from nextcloud/server-frontend

@PVince81 PVince81 Awaiting requested review from PVince81

Assignees

@skjnldsv skjnldsv

Labels
4. to release Ready to be released and/or waiting for tests to finish enhancement feature: files
Projects
Files to vue
Status: Done
Milestone
Nextcloud 26
Development

Successfully merging this pull request may close these issues.
3 participants
@skjnldsv @artonge @come-nc