feat(AppNavigationItem): Allow native title attribute control #3617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skjnldsv
added
3. to review
skjnldsv
requested review from
PVince81,
JuliaKirschenheuter and
marcoambrosini
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
raimund-schluessler
approved these changes
Jan 5, 2023
This comment was marked as resolved.
This comment was marked as resolved.
skjnldsv
force-pushed
the
fix/title-nav-entry
branch
from
beff6ad
to
a5a2f87
Compare
|
Done, please review again @raimund-schluessler |
skjnldsv
force-pushed
the
fix/title-nav-entry
branch
2 times, most recently
from
a8a0ffa
to
5936a88
Compare
skjnldsv
force-pushed
the
fix/title-nav-entry
branch
from
5936a88
to
5f2ff98
Compare
skjnldsv
force-pushed
the
fix/title-nav-entry
branch
from
5f2ff98
to
47cffb4
Compare
skjnldsv
force-pushed
the
fix/title-nav-entry
branch
from
47cffb4
to
33aeadf
Compare
skjnldsv
requested review from
a team,
Pytal and
szaimen
and removed request for
a team
JuliaKirschenheuter
approved these changes
Jan 9, 2023
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
raimund-schluessler
force-pushed
the
fix/title-nav-entry
branch
from
33aeadf
to
a77546a
Compare
|
Rebased. |
skjnldsv
added
4. to release
This was referenced Jan 11, 2023
Merged
Merged
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From nc25 (not vue):
Since we're moving away from tooltips libraries.