Skip to content
This repository has been archived by the owner on Oct 19, 2022. It is now read-only.

[WIP] Staging and new home page #131

Merged
merged 125 commits into from
Oct 6, 2016
Merged

[WIP] Staging and new home page #131

merged 125 commits into from
Oct 6, 2016

Conversation

LukasReschke
Copy link
Member

@LukasReschke LukasReschke commented Sep 13, 2016

@jancborchardt
Copy link
Member

jancborchardt commented Sep 15, 2016

Reeeally great! Good work @Espina2 & @LukasReschke :) Some feedback:

  • the background color switch of the header is too jarring. Let’s try just keeping it blue
  • the interface in those screenshots / device mockups needs to be way zoomed in so it’s properly visible. Also in the mobile device it should show the actual Android app
  • the text of the newsletter button on the bottom needs to be changed from the non-descriptive »Just click here« to »Join our newsletter!«
  • the favicon should be white on blue instead of the current blue on white. Get it from https://github.com/nextcloud/server/tree/master/core/img

That’s the first impression anyhow, need to look closer afterwards. ;)

@Espina2
Copy link
Contributor

Espina2 commented Sep 23, 2016

@LukasReschke how i can have this in a developement environment?

@LukasReschke
Copy link
Member Author

@LukasReschke how i can have this in a developement environment?

Let me get you a quick step-by-step tomorrow. I suppose you use OS X? :-)

@Espina2 Espina2 closed this Sep 23, 2016
@MariusBluem
Copy link
Member

Closed this by mistake? @Espina2 😁

@MariusBluem MariusBluem reopened this Sep 23, 2016
@Espina2
Copy link
Contributor

Espina2 commented Sep 23, 2016

@jospoortvliet Something is broken? Now only show the header.

@jospoortvliet
Copy link
Member

Yeah, something is broken, not sure what or how to fix as it works locally...

@jospoortvliet
Copy link
Member

working now. Sorry ;-)

@skjnldsv
Copy link
Member

skjnldsv commented Oct 6, 2016

@Espina2

Its looks pretty nice to me, and its done the same way in design. We should not change things after that phase.

Well, it feels weird for me 😝
The common way for a menu is 3 lines (or dots, see android material guidelines)

@LukasReschke thanks! I'm having fun now!
😁

@LukasReschke
Copy link
Member Author

@LukasReschke thanks! I'm having fun now!

Btw. please don't do any too dangerous changes right now. I'm trying to get this done into a kinda mergable state to push it live already (otherwise this is going to take a ton of time before we get to merge anything)

Once merged I'll open another staging branch from that we can incremental improve later as well :)

@skjnldsv
Copy link
Member

skjnldsv commented Oct 6, 2016

I only did few small edits. Do you want me to stop for now?

@LukasReschke
Copy link
Member Author

No worries that's fine. :) – Small edits work great! :)

@LukasReschke
Copy link
Member Author

Ok. Merging this and pushing live soon.

@LukasReschke LukasReschke merged commit b4dd7b6 into master Oct 6, 2016
@LukasReschke LukasReschke deleted the staging branch October 6, 2016 15:03
@LukasReschke
Copy link
Member Author

Let's iterate in other pull requests. Thanks folks!

@LukasReschke
Copy link
Member Author

And this is already live at https://nextcloud.com/ 🚀 💃 🎉 🍻 🐘 🦄

Thanks to all of you, and special thanks to the most awesome @Espina2! 🚀

@skjnldsv
Copy link
Member

skjnldsv commented Oct 6, 2016

Yeeepee!

@tcitworld
Copy link
Member

Page doesn't have a title. :(

@skjnldsv
Copy link
Member

skjnldsv commented Oct 6, 2016

A man needs a name!

@jancborchardt
Copy link
Member

Great work! :) Especially thanks to @Espina2, and @LukasReschke and @jospoortvliet :)

(And yeah, the pages need titles again ;) in the style of Pagename – Nextcloud)

@LukasReschke
Copy link
Member Author

(And yeah, the pages need titles again ;) in the style of Pagename – Nextcloud)

Pull request welcome, or well, file an issue 😉 🙈

@LukasReschke
Copy link
Member Author

=> #163

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants