Skip to content

Commit

Permalink
update: make letsencrypt update more resiliant (2)
Browse files Browse the repository at this point in the history
  • Loading branch information
@nachoparker
nachoparker committed Jan 28, 2019
1 parent 55121d4 commit 6331ce5
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 2 deletions.
6 changes: 4 additions & 2 deletions changelog.md
View file
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@

[v1.4.10](https://github.com/nextcloud/nextcloudpi/commit/3231406) (2019-01-27) update: make letsencrypt update more resiliant
[v1.4.11](https://github.com/nextcloud/nextcloudpi/commit/2cd950d) (2019-01-28) update: make letsencrypt update more resiliant (2)

[v1.4.9](https://github.com/nextcloud/nextcloudpi/commit/9a36ceb) (2019-01-25) letsencrypt: use the latest github version
[v1.4.10](https://github.com/nextcloud/nextcloudpi/commit/55121d4) (2019-01-27) update: make letsencrypt update more resiliant

[v1.4.9 ](https://github.com/nextcloud/nextcloudpi/commit/9a36ceb) (2019-01-25) letsencrypt: use the latest github version

[v1.4.8 ](https://github.com/nextcloud/nextcloudpi/commit/338da33) (2019-01-26) ncp-update-nc: fix unnecessary quotes

Expand Down
7 changes: 7 additions & 0 deletions update.sh
View file
Original file line number Diff line number Diff line change
Expand Up @@ -297,6 +297,13 @@ EOF
bash -c "sleep 2 && service apache2 reload" &>/dev/null &
}

# fix LE update bug (2)
if [[ -d /etc/letsencrypt/archive ]] && [[ "$(ls /etc/letsencrypt/archive/* 2>/dev/null | wc -l )" == "0" ]]; then
rmdir /etc/letsencrypt/archive
sleep 3
cp -ravT /etc/letsencrypt-old/archive /etc/letsencrypt/archive || true
bash -c "sleep 2 && service apache2 reload" &>/dev/null &
fi

# remove redundant opcache configuration. Leave until update bug is fixed -> https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=815968
# Bug #416 reappeared after we moved to php7.2 and debian buster packages. (keep last)
Expand Down

3 comments on commit 6331ce5

@enoch85
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a quick question, why use the master from Github and not certbot, any special reason except having "the latest and the greatest"?

@nachoparker
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @enoch85 !

Well, this is the reason

https://help.nextcloud.com/t/ncp-raspbian-letsencrypt-support/45741

Needed to go back to the github version, which sucks :|

@enoch85
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm yeah. Both the Nextcloud Snap and the Nextcloud VM runs Certbot and are also affected since they don't proved TLS-ALPN (yet), but at least the VM uses standalone as a first option. :-]

Please sign in to comment.