Use DIG instead of NSLOOKUP in DDNS apps (#666)

nextcloud · Oct 7, 2018 · c6da8a9 · c6da8a9
1 parent 54e0968
commit c6da8a9
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/etc/ncp-config.d/DDNS_freeDNS.sh b/etc/ncp-config.d/DDNS_freeDNS.sh
@@ -34,7 +34,7 @@ configure()
 #!/bin/bash
 echo "FreeDNS client started"
 echo "${URL}"
-registeredIP=\$(nslookup ${DOMAIN_}|tail -n2|grep A|sed s/[^0-9.]//g)
+registeredIP=$(dig +short "$DOMAIN_"|tail -n1)
 currentIP=\$(wget -q -O - http://checkip.dyndns.org|sed s/[^0-9.]//g)
     [ "\$currentIP" != "\$registeredIP" ] && {
         wget -q -O /dev/null ${URL}

diff --git a/etc/ncp-config.d/DDNS_spDYN.sh b/etc/ncp-config.d/DDNS_spDYN.sh
@@ -87,7 +87,7 @@ if [ $# -eq 3 ]
   	then
   		# if hostname and token
   		# Get registered IP address
-		registeredIP=\$(nslookup ${DOMAIN_}|tail -n2|grep A|sed s/[^0-9.]//g)
+		registeredIP=$(dig +short "$DOMAIN_"|tail -n1)
 		# Get current IP address
 		currip=$(curl -s "$get_ip_url");
 		# Update only when IP address has changed.
@@ -102,7 +102,7 @@ if [ $# -eq 3 ]
 		then
 			# if hostname and user and passwd
 			# Get registered IP address
-			registeredIP=\$(nslookup ${DOMAIN_}|tail -n2|grep A|sed s/[^0-9.]//g)
+			registeredIP=$(dig +short "$DOMAIN_"|tail -n1)
 			# Get current IP address
 			currip=$(curl -s "$get_ip_url");
 			# Update only when IP address has changed.