Skip to content

Letsencrypt: support second domain #1025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nachoparker merged 7 commits into from
Nov 18, 2019
Merged

Letsencrypt: support second domain #1025

nachoparker merged 7 commits into from
Nov 18, 2019

Conversation

@rababerladuseladim
Copy link
Contributor

@rababerladuseladim rababerladuseladim commented Nov 10, 2019 •
edited
Loading

The ncp letsencrypt app now allows a second domain to be specified.
Fix: #837

@rababerladuseladim rababerladuseladim force-pushed the letsencrpyt_multi_domain_support branch 2 times, most recently from 0e99f6c to ba199c9 Compare November 10, 2019 16:29
@iTom1192
Copy link

iTom1192 commented Nov 11, 2019

Please forgive me if I've overlooked this but how do I add the second domain? I don't see the option when using sudo ncp-config and I am not sure what file to look in to manually add it.

@rababerladuseladim
Copy link
Contributor Author

rababerladuseladim commented Nov 11, 2019

It is not in nextcloudpi yet. This thread is a request to include the code that enables it.

nachoparker
nachoparker approved these changes Nov 16, 2019
View reviewed changes
Copy link
Member

@nachoparker nachoparker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking great, thanks!

please see a couple comments below

mad73923 and others added 7 commits November 17, 2019 15:52
@mad73923 @rababerladuseladim
docker: fixing file permission for redis config (nextcloud#1021)
5c80775 
Signed-off-by: Matthias Weis <matthias1.weis@web.de>
Signed-off-by: Henning Schiebenhoefer <henning.schiebenhoefer@posteo.de>
@rababerladuseladim
letsencrypt: support additional domain in ncp-app
7c467a8 
Signed-off-by: Henning Schiebenhoefer <henning.schiebenhoefer@posteo.de>
@rababerladuseladim
letsencrypt: leave default for additional domain empty
13c91ed 
Signed-off-by: Henning Schiebenhoefer <henning.schiebenhoefer@posteo.de>
@rababerladuseladim @nachoparker
Update bin/ncp/CONFIG/nc-limits.sh
dd702e1 
Co-Authored-By: nachoparker <nacho@ownyourbits.com>
Signed-off-by: Henning Schiebenhoefer <henning.schiebenhoefer@posteo.de>
@rababerladuseladim @nachoparker
Update bin/ncp/NETWORKING/letsencrypt.sh
15fe0a0 
Co-Authored-By: nachoparker <nacho@ownyourbits.com>
Signed-off-by: Henning Schiebenhoefer <henning.schiebenhoefer@posteo.de>
@rababerladuseladim @nachoparker
Update bin/ncp/NETWORKING/letsencrypt.sh
649e493 
Co-Authored-By: nachoparker <nacho@ownyourbits.com>
Signed-off-by: Henning Schiebenhoefer <henning.schiebenhoefer@posteo.de>
@rababerladuseladim @nachoparker
Update bin/ncp/NETWORKING/letsencrypt.sh
f069a93 
Co-Authored-By: nachoparker <nacho@ownyourbits.com>
Signed-off-by: Henning Schiebenhoefer <henning.schiebenhoefer@posteo.de>
@rababerladuseladim rababerladuseladim force-pushed the letsencrpyt_multi_domain_support branch from ec55649 to f069a93 Compare November 17, 2019 14:53
@nachoparker nachoparker merged commit 7317ce8 into nextcloud:devel Nov 18, 2019
@nachoparker
Copy link
Member

nachoparker commented Nov 18, 2019

many thanks

nachoparker added a commit that referenced this pull request Nov 18, 2019
@rababerladuseladim @nachoparker
Letsencrypt: support second domain (#1025)
86fbc5b 
Co-Authored-By: nachoparker <nacho@ownyourbits.com>
Signed-off-by: Henning Schiebenhoefer <henning.schiebenhoefer@posteo.de>
Signed-off-by: nachoparker <nacho@ownyourbits.com>
nachoparker pushed a commit that referenced this pull request Nov 18, 2019
@rababerladuseladim @nachoparker
Letsencrypt: support second domain (#1025)
e975320
@nachoparker
Copy link
Member

nachoparker commented Nov 18, 2019

I tested it with one domain and it seems to work fine. I did a couple minor changes, so could you please confirm that it works for you still with two domains?

Just run sudo ncp-update devel and run it, let me know if still works ok, then we'll merge it.

Cheers

@rababerladuseladim
Copy link
Contributor Author

rababerladuseladim commented Nov 19, 2019

I tested it with one domain and it seems to work fine. I did a couple minor changes, so could you please confirm that it works for you still with two domains?

Just run sudo ncp-update devel and run it, let me know if still works ok, then we'll merge it.

Cheers

Tested and works.

nachoparker pushed a commit that referenced this pull request Nov 30, 2019
@rababerladuseladim @nachoparker
Letsencrypt: support second domain (#1025)
310877f
@langfingaz langfingaz mentioned this pull request Dec 16, 2019
Closed
@joshtrichards joshtrichards mentioned this pull request Jun 17, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nachoparker nachoparker nachoparker approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rababerladuseladim @iTom1192 @nachoparker @mad73923