Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposed fix for issue #772 #782

Merged
merged 1 commit into from
Jan 22, 2019
Merged

Proposed fix for issue #772 #782

merged 1 commit into from
Jan 22, 2019

Conversation

necopinus
Copy link
Contributor

Proposed fix for issue #772. To recap:

Right now, enabling dnsmasq within a NextCloudPi Docker container associates your $DOMAIN with the container's private IP address. This means that Docker images cannot use dnsmasq to redirect systems on your home network to your NextCloudPi server.

This change sets the IP address corresponding to your Nextcloud $DOMAIN to the IP (optionally) passed into the docker image (which is stored by 020nextcloud in trusted_domains 6). If trusted_domains 6 is empty or is not an IP address, fall back to the previous behavior.

Tested on my "production" home NextCloudPi server. Note that I only have access to that server and a Chromebook right now, so my ability to test this change more fully is limited.

@nachoparker nachoparker merged commit 0e062aa into nextcloud:devel Jan 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants