Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.12.0 #241

Closed
6 tasks done
stefan-niedermann opened this issue Aug 27, 2017 · 7 comments
Closed
6 tasks done

v0.12.0 #241

stefan-niedermann opened this issue Aug 27, 2017 · 7 comments
Milestone

Comments

@stefan-niedermann
Copy link
Member

stefan-niedermann commented Aug 27, 2017

Okay folks,

this is the plan to release the next version!

Pull Requests to merge:

Sorry, #207 Vibrate on list item move and #202 Links between notes will have to wait since there are still discussion points.

After merging those three, we will test for a while and if there no problem occurs, we will tag the version (leads to build on f-droid).
Then we will wait for a while and then release v0.12.0 on Play Store.

CC @schaarsc @dan0xii and of course @korelstar

Thank you very much for your patience. Please solve the remaining conflicts and then let's go 🚀 !

@stefan-niedermann stefan-niedermann added this to the 0.12.0 milestone Aug 27, 2017
@korelstar
Copy link
Member

One hint: give the transifex community some time to translate new strings from merged PRs before merging #240 (Transifex Update) and tagging a new release. Otherwise, there will be many untranslated strings in the release.

@stefan-niedermann
Copy link
Member Author

Okay everyone. Have i missed anything? App seems to work fine.

@dan0xii can you please give me an update of the widget state? (master and dan0xii:widget_single_note_scroll2 branches - what is still on the branch, do we need it for the next release?)

Otherwise i think we can merge transifex and release.

PS.: @schaarsc and @dan0xii can you please contact me via email at info@niedermann.it? I had recently a conversation with @korelstar and have got some candy for you)

@korelstar
Copy link
Member

I suggest to wait for #263 before releasing. I will test the current state (with #263) on my phone in the meanwhile ...

@dan0xii
Copy link
Collaborator

dan0xii commented Oct 1, 2017

Before I saw korelstar's comment I was going to suggest leaving #263 until the next release so that 0.12.0 isn't delayed too much but if you're happy to wait then it does make the widget a lot more functional.

I've been using it on my phone since I made the PR and haven't encountered any issues.

The remaining code to merge is still needed to enable scrolling and basically sets the widget to use a listview with the single textview containing the note content as its child. I've used this to create an "all notes" widget also which I've been running on my phone. This widget has #263 as a prerequisite so I've delayed making a PR until it's merged.

@korelstar
Copy link
Member

Good work (the ListView is a nice idea) :-)

I found no problems, so I would merge #263 and #240 and then release!

@stefan-niedermann
Copy link
Member Author

Aggree, everything should be in master now.

I will tag tonight or tomorrow.

@stefan-niedermann
Copy link
Member Author

Didn't managed it yesterday, will tag as soon as possible...

stefan-niedermann added a commit that referenced this issue Oct 4, 2017
Version bump
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants