Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add function to see how many characters the note has #1173

Closed
wants to merge 1 commit into from
Closed

Add function to see how many characters the note has #1173

wants to merge 1 commit into from

Conversation

Cui-Yusong
Copy link
Contributor

By changing the generateNoteExcerpt method, calculate and save the number of characters of the article when generating excerpt.

@stefan-niedermann
Copy link
Member

Thank you for your contribution.
However, this is a quick shot and there are so many issues with this PR that i can not merge it.

  1. Our workflow / process is to first discuss ideas and then implement it. This avoids unnecessary work, frustration when something won't get merged and gives us a common, shared idea about the goal
  2. I am not sure yet whether we really want to have this feature. I clutters the UI for everyone who don't care about the count and a separate option will need to be tested and maintained in the future.
  3. All strings are hard coded, therefore not translatable.
  4. You are talking about a "Word count" but implemented a "Character count". So now we have differences in the feature request, the implementation, the description in the UI and the general understanding
  5. The feature request was to see the counter within the note, not in the list (where it makes even less sense in my personal opinion). Though, let's discuss this before doing such actions. Maybe a circle like a WhatsApp unread counter at the right makes more sense?
  6. Simply removing unit tests without an appropriate reason is inacceptible.

I can imagine some kind of new "Details" view for the title, category, modified date and other meta information, though this needs to be thought well and discuessed with the UX / design team of Nextcloud. We will not do any quick shot here.

@Cui-Yusong
Copy link
Contributor Author

Yesterday I under #1087 provides an idea about the function of the word counting.I personally feel that this solution is not very difficult, so I have already finished this feature before your reply.
I'm sorry that there are still some problems with this idea. I will code after getting your reply next time.
Sorry to get you some troubles.

@stefan-niedermann
Copy link
Member

Absolutely no problem 🙂 Also please don't feel offended - looking forward to further contributions in the future :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants