Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1079 Show DisplayName instead of uid attribute for LDAP users #1211

Merged
merged 12 commits into from
May 12, 2021
Merged

#1079 Show DisplayName instead of uid attribute for LDAP users #1211

merged 12 commits into from
May 12, 2021

Conversation

stefan-niedermann
Copy link
Member

@stefan-niedermann stefan-niedermann commented May 11, 2021 •
edited
Loading

  • Fetch displayName and store it in database
  • Use displayName instead of userName on the UI
  • Check whether ETags are supported for this endpoint (No: Support ETags for /ocs/v2.php/cloud/users/{userId} endpoint (or all ocs endpoints?) server#26947)
  • Check when we actually have to update this
    • Importing the first account
    • Importing further accounts
    • Pull 2 Refresh Probably too much traffic consumption until ETags have been implemented
    • Background synchronization (24h via CapabilitiesWorker)
  • Database migration
  • Test on Android 5 device because of COALESCE SQL operator

@stefan-niedermann stefan-niedermann linked an issue May 11, 2021 that may be closed by this pull request
Show DisplayName instead of uid attribute for LDAP users #1079
Closed
@stefan-niedermann stefan-niedermann marked this pull request as ready for review May 11, 2021 19:30
@stefan-niedermann stefan-niedermann merged commit 5cc8544 into master May 12, 2021
@stefan-niedermann stefan-niedermann deleted the 1079-display-name-instead-of-user-id branch May 12, 2021 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Show DisplayName instead of uid attribute for LDAP users
1 participant
@stefan-niedermann