Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set minSdkVersion to 24 + remove checks #1726

Merged
merged 2 commits into from
Apr 17, 2023
Merged

Set minSdkVersion to 24 + remove checks #1726

merged 2 commits into from
Apr 17, 2023

Conversation

tobiasKaminsky
Copy link
Member

No description provided.

AndyScherzinger
AndyScherzinger requested changes Apr 11, 2023
View reviewed changes
Copy link
Member

@AndyScherzinger AndyScherzinger left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unit tests failing with

 java.lang.RuntimeException at ShadowPackageParser.java:70
        Caused by: android.content.pm.PackageParser$PackageParserException at PackageParser.java:892

@tobiasKaminsky
Copy link
Member Author

@stefan-niedermann do you have an idea why it fails with unit tests?

java.lang.RuntimeException: android.content.pm.PackageParser$PackageParserException: /home/tobi/github/nextcloud/notes-android/app/build/intermediates/apk_for_local_test/devDebugUnitTest/apk-for-local-test.ap_ (at Binary XML file line #7): Requires newer sdk version #24 (current version is #23)
	at org.robolectric.shadows.ShadowPackageParser.callParsePackage(ShadowPackageParser.java:70)
	at org.robolectric.android.internal.AndroidTestEnvironment.loadAppPackage_measured(AndroidTestEnvironment.java:404)
	at org.robolectric.android.internal.AndroidTestEnvironment.lambda$loadAppPackage$3(AndroidTestEnvironment.java:376)
	at org.robolectric.util.PerfStatsCollector.measure(PerfStatsCollector.java:53)
	at org.robolectric.android.internal.AndroidTestEnvironment.loadAppPackage(AndroidTestEnvironment.java:376)
	at org.robolectric.android.internal.AndroidTestEnvironment.installAndCreateApplication(AndroidTestEnvironment.java:273)
	at org.robolectric.android.internal.AndroidTestEnvironment.lambda$createApplicationSupplier$0(AndroidTestEnvironment.java:245)
	at org.robolectric.util.PerfStatsCollector.measure(PerfStatsCollector.java:53)
	at org.robolectric.android.internal.AndroidTestEnvironment.lambda$createApplicationSupplier$1(AndroidTestEnvironment.java:242)
	at com.google.common.base.Suppliers$NonSerializableMemoizingSupplier.get(Suppliers.java:183)
	at org.robolectric.RuntimeEnvironment.getApplication(RuntimeEnvironment.java:72)
	at org.robolectric.android.internal.AndroidTestEnvironment.setUpApplicationState(AndroidTestEnvironment.java:210)
	at org.robolectric.RobolectricTestRunner.beforeTest(RobolectricTestRunner.java:331)
	at org.robolectric.internal.SandboxTestRunner$2.lambda$evaluate$2(SandboxTestRunner.java:278)
	at org.robolectric.internal.bytecode.Sandbox.lambda$runOnMainThread$0(Sandbox.java:99)
	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:317)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1144)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:642)
	at java.base/java.lang.Thread.run(Thread.java:1589)
Caused by: android.content.pm.PackageParser$PackageParserException: /home/tobi/github/nextcloud/notes-android/app/build/intermediates/apk_for_local_test/devDebugUnitTest/apk-for-local-test.ap_ (at Binary XML file line #7): Requires newer sdk version #24 (current version is #23)
	at android.content.pm.PackageParser.parseBaseApk(PackageParser.java:892)
	at android.content.pm.PackageParser.parseMonolithicPackage(PackageParser.java:838)
	at android.content.pm.PackageParser.parsePackage(PackageParser.java:756)
	at org.robolectric.shadows.ShadowPackageParser.callParsePackage(ShadowPackageParser.java:48)
	... 18 more

@stefan-niedermann
Copy link
Member

Adjust new minSdk here: https://github.com/nextcloud/notes-android/blob/main/app/src/test/resources/robolectric.properties

tobiasKaminsky and others added 2 commits April 17, 2023 14:22
@tobiasKaminsky @AndyScherzinger
Set minSdkVersion to 24 + remove checks
05cfad7 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@AndyScherzinger
bump robolectric to min 24
ec519d9 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger AndyScherzinger self-requested a review April 17, 2023 12:39
@AndyScherzinger AndyScherzinger merged commit 9a716a1 into main Apr 17, 2023
@AndyScherzinger AndyScherzinger deleted the mindSdkVersion24 branch April 17, 2023 12:40
@AndyScherzinger AndyScherzinger added this to the 4.1.0 milestone Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefan-niedermann stefan-niedermann stefan-niedermann approved these changes

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes

Assignees
No one assigned
Labels
3. to review
Projects
None yet
Milestone
4.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@tobiasKaminsky @stefan-niedermann @AndyScherzinger