Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

speed-up synchronization and introduce categories #181

Merged
merged 1 commit into from
Mar 3, 2017

Conversation

korelstar
Copy link
Member

Since #167 has to be reworked (see discussion in nextcloud/notes#51), I've extracted all changes I made there that do not belong to optimizations on the server API. Therefore, this PR is ready to merge and I will work on #167 later. This has the advantage that we can work on categories and do not have to wait until nextcloud/notes#51 is ready (and we have a smaller PR).

This PR includes:

  • synchronize (read-only) category and show category in NotesListViewActivity (cp. Support Categories #165)
  • add category and etag to database (etag is not yet used, but will in the near future, see Manage concurrent edits of notes notes#56)
  • create database indexes (speed-up!)
  • reduce size of database-requests (only IDs instead of whole notes) in order to speed-up synchronization (significant for slow devices!)
  • NoteSQLiteOpenHelper has become a singleton (this was helpful during development)
  • some minor optimizations

@stefan-niedermann
Copy link
Member

ready to merge?

@korelstar
Copy link
Member Author

korelstar commented Feb 26, 2017 via email

@stefan-niedermann stefan-niedermann merged commit ac63b64 into master Mar 3, 2017
@korelstar korelstar deleted the sync-speedup1 branch March 3, 2017 18:18
@korelstar korelstar added this to the 0.10.0 milestone Mar 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants