-
-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Translate App Store Description into English #1847
base: main
Are you sure you want to change the base?
Conversation
64cacbe
to
68f83ee
Compare
@thgoebel The Nextcloud GmbH took over maintenance of the Notes Android app and I therefore do no longer have any control about release aspects. Fastlane usually respects the translations and should the publish with the next release. However, I am not sure whether this solution (a manual translation) is wanted or if Nextcloud GmbH wants to let the translations also handle by the Transifex Nextcloud community... There is a risc of outdated translations when changing the original text without having set up a proper translation pipeline.... 🤷♂️ |
Hello there, We hope that the reviewing process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR reviewing process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! |
I searched around, and as far as I can see it's not straightforward to set up Transifex--Fastlane--integration. Right now I don't have more time to invest such integration. I'd prefer if someone from Nextcloud GmbH could do that. Also good for internal knowledge sharing so that they can do it for all apps, I guess. So I'd leave it up to Nextcloud GmbH to decide whether
|
68f83ee
to
3ca2b42
Compare
@tobiasKaminsky and the team know more about it since I think the Files client uses fastlane and also makes use of transifex for app store text translations. |
3ca2b42
to
4f538b7
Compare
4f538b7
to
9020721
Compare
The description was initially in English and German but in the commit by a mistake they were messed bf25ed5 |
Fixes nextcloud#1841 (upon the next F-Droid release). Fixes nextcloud#1796 (upon the next Fastlane sync to Play Store). Signed-off-by: Thore Goebel <goebel.thore@gmail.com>
Now that Nextcloud Notes for Android is an official Nextcloud project these points no longer apply. Signed-off-by: Thore Goebel <goebel.thore@gmail.com>
9020721
to
7d7e748
Compare
This PR fixes #1841 (F-Droid) and #1796 (Google Play).
F-Droid should pickup the translation with the next app release.
With Google Play/Fastlane I am not 100% sure if/how Fastlane pushes these to Google Play. @stefan-niedermann could you please double-check this during the next release, that they are uploaded to Google Play?