Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide notes when app is locked #1905

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

F462
Copy link

@F462 F462 commented Sep 26, 2023

In this PR, the notes are not loaded before the app is unlocked, which one the one hand still preserves the app impression while locked, while at the same time hiding the sensitive data. This solves #927 .

Since I'm quite new to the code, I cannot really judge if this approach is valid. However, it seems to achieve the expected result without side effects (tested on Android 13).

The notes are still shown in the app preview when minimized, which is a separate issue.

In addition, the time based app locking doesn't seem to work on the main screen, which isn't supported by these changes here, either.

Signed-off-by: Fabian Diener <f46200@gmail.com>
Signed-off-by: Fabian Diener <f46200@gmail.com>
Signed-off-by: Fabian Diener <f46200@gmail.com>
@F462 F462 force-pushed the hide-notes-when-locked branch from c4345fa to d052d96 Compare September 27, 2023 15:15
@github-actions
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the reviewing process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR reviewing process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

@stefan-niedermann
Copy link
Member

Hmm, might work (didn't check it due to missing sparetime at runtime).

However, looking at three different banking apps it seems an dedicated UnlockActicity seems the way to go to solve Googles shit show eventually. 🤷

cc @tobiasKaminsky and @AndyScherzinger for their opinion

@AndyScherzinger
Copy link
Member

I agree @stefan-niedermann with the assessment regarding a dedicated activity. This is also how we do it on files and talk.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants