Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkboxes in Widget #1912

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

newhinton
Copy link
Contributor

Fixes #1907
Requires: stefan-niedermann/nextcloud-commons#215

This implements checkable-checkboxes on devices with api 31 or greater.

image

This is a first working prototype.
It can:

  • Display a checkbox for chechbox items
  • Handle the state correctly

It cannot:

  • Display checkbox-text nice. The raw-markdown is currently not stripped
  • Send a checkbox event back to the app
  • Render the notes good. (With each markdown block, there is a margin at the bottom)

Since this requires changes in the nextcloud-common library, i would like to ask for a general review now, before i continue.

@github-actions
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the reviewing process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR reviewing process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

@AndyScherzinger AndyScherzinger force-pushed the feature/1907/widgetcheckboxes branch from d4859d0 to 13c1976 Compare January 21, 2024 15:47
@AndyScherzinger
Copy link
Member

Rebased due to major technical updates in terms of libraries, especially AGP and SSO

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Single Note Widget should have check-able checkboxes
2 participants