chore: Bump max-version of PHP to 8.3

Signed-off-by: Julius Härtl <jus@bitgrid.net>
nextcloud · Dec 28, 2023 · 4a95063 · 4a95063
1 parent 9d74767
commit 4a95063
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 6 deletions.
diff --git a/appinfo/info.xml b/appinfo/info.xml
@@ -21,7 +21,7 @@ The Notes app is a distraction free notes taking app for [Nextcloud](https://www
 	<repository type="git">https://github.com/nextcloud/notes.git</repository>
 	<screenshot small-thumbnail="https://raw.githubusercontent.com/nextcloud/screenshots/master/apps/Notes/notes-thumbnail.jpg">https://raw.githubusercontent.com/nextcloud/screenshots/master/apps/Notes/notes.png</screenshot>
 	<dependencies>
-		<php min-version="7.4" max-version="8.2"/>
+		<php min-version="7.4" max-version="8.3"/>
 		<nextcloud min-version="25" max-version="29"/>
 	</dependencies>
 	<repair-steps>

diff --git a/lib/AppInfo/Application.php b/lib/AppInfo/Application.php
@@ -12,6 +12,7 @@
 use OCP\EventDispatcher\GenericEvent;
 use OCP\EventDispatcher\IEventDispatcher;
 use OCP\Share\Events\BeforeShareCreatedEvent;
+/** @phan-suppress-next-line PhanUnreferencedUseNormal */
 use OCP\Share\IShare;
 
 class Application extends App implements IBootstrap {
@@ -43,6 +44,7 @@ public function register(IRegistrationContext $context): void {
 				}
 
 				/** @var IShare $share */
+				/** @phan-suppress-next-line PhanDeprecatedFunction */
 				$share = $event->getSubject();
 
 				$modernListener = \OCP\Server::get(BeforeShareCreatedListener::class);

diff --git a/lib/AppInfo/BeforeShareCreatedListener.php b/lib/AppInfo/BeforeShareCreatedListener.php
@@ -16,6 +16,7 @@
 class BeforeShareCreatedListener implements IEventListener {
 	private SettingsService $settings;
 	private NoteUtil $noteUtil;
+	private LoggerInterface $logger;
 
 	public function __construct(SettingsService $settings, NoteUtil $noteUtil, LoggerInterface $logger) {
 		$this->settings = $settings;

diff --git a/tests/phan-config.php b/tests/phan-config.php
@@ -1,11 +1,18 @@
 <?php
 
+echo getenv('NC_API_TAG');
+
+$testDirs = [
+	'lib/',
+	'vendor/',
+];
+
+if (getenv('NC_API_TAG') === 'dev-stable25') {
+	$testDirs[] = 'tests/stubs/';
+}
+
 return [
-	'directory_list' => [
-		'lib/',
-		'vendor/',
-		'tests/stubs/',
-	],
+	'directory_list' => $testDirs,
 	"exclude_analysis_directory_list" => [
 		'vendor/',
 	],