Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use EasyMDE for Preview #329

Closed
tnyeanderson opened this issue Jun 24, 2019 · 2 comments
Closed

Use EasyMDE for Preview #329

tnyeanderson opened this issue Jun 24, 2019 · 2 comments
Labels
enhancement New feature or request needs discussion Need to clarify if and how we should implement this

Comments

@tnyeanderson
Copy link
Contributor

tnyeanderson commented Jun 24, 2019

I took a look; we should definitely be using EasyMDE's preview functionality instead of Markdown-It. It supports checkboxes out of the box and prevents us from requiring another library. Here's what EasyMDE does not support that Markdown-It does:

  • Emojis
  • Blockquotes
  • Images (displayed as block instead of inline, larger size
  • Sub/Superscript
  • Inserted text
  • Marked text
  • Footnotes
  • Definition lists
  • Custom Containers

Since we don't support these features anyway, making the switch makes sense.

Some useful notes for implementation:
Check if we are in preview mode: easyMDE.isPreviewActive();
Toggle preview mode: easyMDE.togglePreview()

This should be easy to implement. Then we can get rid of Markdown-It, AND have checkboxes available in preview mode :)

@tnyeanderson tnyeanderson added enhancement New feature or request needs discussion Need to clarify if and how we should implement this labels Jun 24, 2019
@korelstar
Copy link
Member

This will be obsolete due to #331. Did you already did some implementation on this or can we safely close this issue, @tnyeanderson?

@tnyeanderson
Copy link
Contributor Author

You're absolutely right. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request needs discussion Need to clarify if and how we should implement this
Projects
None yet
Development

No branches or pull requests

2 participants