Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate Nextcloud Text #331

Closed
korelstar opened this issue Jun 28, 2019 · 3 comments · Fixed by #958
Closed

Integrate Nextcloud Text #331

korelstar opened this issue Jun 28, 2019 · 3 comments · Fixed by #958
Labels
feature: editor Related to generic parts of the editor, e.g. loading/saving notes feature request Requests for complete new features
Milestone

Comments

@korelstar
Copy link
Member

korelstar commented Jun 28, 2019

Recently, Nextcloud Text was published: https://nextcloud.com/blog/nextcloud-introduces-collaborative-rich-text-editor/

This is a new rich text editor using markdown and providing collaborative editing. The plan is to integrate that editor into the notes app in order to have a common editor with all new features, but at the same time, make managing notes easy without thinking about files and directories (see discussion at nextcloud/text#6)

@juliushaertl announced that he will start working on the integration of Text in the Notes app (nextcloud/text#6 (comment)). This issue here is just an information for users and developers that this integration is planned. I think it could fix #285, #38, #204, #310, #308, #329 and maybe some others. But let's see 😉


Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@korelstar korelstar added enhancement New feature or request feature: editor Related to generic parts of the editor, e.g. loading/saving notes labels Jun 28, 2019
@korelstar korelstar added this to the 4.0.0 milestone Jun 28, 2019
@korelstar korelstar pinned this issue Jun 28, 2019
@korelstar korelstar added feature request Requests for complete new features and removed enhancement New feature or request labels Dec 14, 2019
@korelstar
Copy link
Member Author

Some information about the current state of this: I've implemented a proof-of-concept for the Text app's editor integration (see #652). Principally, it works already! However, there are some issues in the Text app that hinder me from finishing this. Mainly, these are:

  • The Text app re-builds the whole Note when saving, using the CommonMark specification. This means that all formatting in the source code (e.g. line-breaks without effects for Markdown parsing) as well as additional non-Markdown parts is lost and Markdown is re-created using a predefined code style (e.g. list items are build with * item, even when they where originally - item). In my opinion, this is a show-stopper, since many people use notes with existing files that must still be processable by the original app that created those files. This issue is documented in Markdown files from external editors lose formatting on save text#593 and Markdown files are corrupted text#772 .
  • Changing a note outside of the Text app (e.g. using the Notes Android app) leads to sync conflicts, even if the file wasn't changed in the Text app for some time. In such a situation, I expect the Text app to silently update the content. This issue is documented in sync causes conflict even if no edits have occurred text#1212 .

Of course, there are some other things to be improved, since I've implemented a proof-of-concept, only. But these two are the biggest things and I think they will need much efforts.

Furthermore, I want to point to the different Markdown styles: The current edit mode allows for flexible line-breaks, e.g. split two list parts by inserting an empty line (see screenshots in #652). This is not possible in Text, since it's not (easily) possible in CommonMark. Honestly, I'm not happy with that, but maybe we have to get accustomed to this.

@jotoeri
Copy link
Member

jotoeri commented Jan 23, 2021

Huh - just to give my 5 cents here:

I really like the Markdown handling as it is currently on the Notes App. Some mixed thing out of WYSIWYG and the plain text. It is somewhere in between the pure markdown (which allows me to easily format my note) and the result of a formatted document. I can just change my markdown syntax and see on the same view the appropriate result. Isn't that the best handling of markdown?

In contrast, on the pure WYSIWYG text app (despite the shitty md-storing), i can't easily edit a set markdown formatting. E.g. code-blocks which i just can't remove anymore from the existing text (preserving the text!), as i can not access the md-operators. Sharps, that i must re-type in plain text and then press space to apply the formatting on headers - that's just counter-intuitive!


So - from my side: Please keep that great WYSI Nearly WYG functionality! 🙏
There can be of course improvements to how it renders currently, but i love the basic approach!

@bgravato
Copy link

bgravato commented Mar 3, 2021

I came here to post a feature suggestion: the ability to display both edit mode and preview mode simultaneously side-by-side (and update preview on the fly). Something similar to what some (desktop) markdown editors do, such as formiko.

Of course I first searched to check if anyone had already posted such feature request and that brought me here...

I must confess I'm not a big fan of the Text app... and I totally agree with @jotoeri comment above.

I also use the android app and I'm a bit worried after reading @korelstar comment on the sync issues.

I understand a pure WYISWYG editor is probably more appealing for the common user who don't understand/don't care for markdown, but for me I think it will negatively impact Notes usability.
If Text app implementation goes forward I hope that there will be a setting available to choose between the Text app or the current editor as the default editor for notes.

Last but not least, thank you very much for providing such great software as nextcloud and nextcloud notes app and all the hard work behind it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: editor Related to generic parts of the editor, e.g. loading/saving notes feature request Requests for complete new features
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants