Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync causes conflict even if no edits have occurred #1212

Closed
brainchild0 opened this issue Nov 29, 2020 · 7 comments
Closed

sync causes conflict even if no edits have occurred #1212

brainchild0 opened this issue Nov 29, 2020 · 7 comments
Labels
enhancement New feature or request needs info

Comments

@brainchild0
Copy link

If a file is open in the editor, but has not been changed, and if an updated version is pushed from a client through file synchronization, then the editor reports a conflict, instead of simply loading the new version pushed from the client.

Worse, the same behavior occurs even when the editor is active in viewing mode, as for a read-only public share.

The following steps will reproduce the issue:

  1. Create a file in a synchronized folder. Be sure that the desktop client is running and that synchronization is enabled.
  2. Open the file in the editor. Make no changes.
  3. Open the file in an editor running locally on the client system. Make changes and save. Allow the file to synchronize with the server.
  4. Return to the editor in the browser.

Then the editor in the browser should simply refresh the content from the local changes.

Presently, the editor reports a conflict, and asks the user to choose between the two versions to resolve the conflict. (In viewing mode, the editor simply continues to display the outdated version.)


Text app version: 3.1.0
Operating system: Linux
Web server: Apache
Database: MariaDB
PHP version: 7.3.24
Nextcloud version: 20.0.2

@brainchild0 brainchild0 added the bug Something isn't working label Nov 29, 2020
@arnowelzel
Copy link

I can confirm this, happens here as well.

@juliusknorr
Copy link
Member

Thanks for your bug report. Please fill out the issue template to provide some more information about your setup and possible errors in the logfiles.

@claell
Copy link

claell commented Mar 13, 2021

This might be caused by #593.

@Ellpeck
Copy link

Ellpeck commented Sep 10, 2022

Is there any update on this?

This issue makes it pretty much impossible to use Text's view feature to share documents with other people if they're being edited locally. I'd love to use the Text preview view to share some of my notes with other people, but because I edit them on my computer rather than on Nextcloud, I keep having to go there to resolve conflicts, even though I never actually edit the file in Text.

@Raudius
Copy link
Contributor

Raudius commented Nov 16, 2022

If I am understanding the issue correctly this sounds like a feature request for syncing text sessions with external changes.

This might be possible when opening files read-only. If a conflict occurs we can reload the document from server as the read-only session is not making changes anyway.

@Raudius Raudius added enhancement New feature or request and removed bug Something isn't working needs triage: raul labels Nov 16, 2022
@juliusknorr
Copy link
Member

Agreed, this is kind of what #233 describes so I'd close this one as a duplicate.

@brainchild0
Copy link
Author

If I am understanding the issue correctly this sounds like a feature request for syncing text sessions with external changes.

There are different assumptions. To my mind, a session opens when the user commits new content, not when the content is viewed. Discovering a conflict as though content were separately modified, when only one source of modification has occurred, is a bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request needs info
Projects
None yet
Development

No branches or pull requests

7 participants