Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codingstyle cache file in distribution tarball #642

Closed
hannob opened this issue Dec 3, 2020 · 0 comments · Fixed by #644
Closed

Codingstyle cache file in distribution tarball #642

hannob opened this issue Dec 3, 2020 · 0 comments · Fixed by #644
Labels
maintenance Software maintenance, e.g. refactoring, improve code quality, documentation etc.
Milestone

Comments

@hannob
Copy link

hannob commented Dec 3, 2020

Describe the bug

The download tarball (notes.tar.gz) contains a file named .php_cs.cache.

This is an artifact of the PHP-CS-Fixer tool, a codingstyle checker for PHP. I assume this was added by mistake, as there seems no point to ship such a cache file in a release. You may want to make sure to do something in your tarball creation pipeline to avoid this more generally.

The file does not seem to be part of the repo. You still may want to consider adding it to .gitignore.

To be clear: This file is not harmful, it's just a useless artifact.

@stefan-niedermann stefan-niedermann added the maintenance Software maintenance, e.g. refactoring, improve code quality, documentation etc. label Dec 3, 2020
@korelstar korelstar added this to the 4.0.2 milestone Dec 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Software maintenance, e.g. refactoring, improve code quality, documentation etc.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants