Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to include multiple folders from separate locations #670

Open
jotoeri opened this issue Jan 22, 2021 · 18 comments
Open

Allow to include multiple folders from separate locations #670

jotoeri opened this issue Jan 22, 2021 · 18 comments
Labels
enhancement New feature or request needs discussion Need to clarify if and how we should implement this

Comments

@jotoeri
Copy link
Member

jotoeri commented Jan 22, 2021

Is your feature request related to a problem? Please describe.
Using the App for shared notes, as well as for private ones, there is still only one notes folder to share. Notes just get created there, independent of it's sharing status. Also when having a own folder-structure, it is not possible to use notes from separate folders.

Describe the solution you'd like
It would be cool, if one could just add arbitrary folders to be read by the app, that then appear just as the current categories. Advanced version of this feature would then be to allow admins to add such folders for all users within settings.

Describe alternatives you've considered

  • Packing all data within one Notes Folder?
  • Creating separate folders within the notes folder, that then can be shared?
@jotoeri jotoeri added needs discussion Need to clarify if and how we should implement this feature request Requests for complete new features labels Jan 22, 2021
@stefan-niedermann
Copy link
Member

Just an idea: Have you tried to mount different subfolders e. g. via WebDAV into the Notes folder?

@jotoeri
Copy link
Member Author

jotoeri commented Jan 23, 2021

Hm, thats one possible workaround, yes. But seems to be quite slow on opening and storing again. However that brought me to another workaround of a symlink on the server, which indeed requires root access, but is much faster than external storage. Thanks for this idea @stefan-niedermann 👍

Still, manually selecting different folders within the settings would be a really cool thing and would in my opinion increase the flexibility of that app quite much! :)

@stefan-niedermann
Copy link
Member

Yes, i have concerns regarding the maintenance of this feature though. Practically it would end up with each selected folder to be a roor category - there are various cases which aren't both, easy to maintain and easy to understand for users, for example "why can't i create a note without a category?". It would also be lots of effort to decide (or implement choices) what happens to the notes when switching between "single folder" mode and "multi folder mode"

From my side it is unfortunately a 👎 because it seems to be an edgecase with several working workarounds and the ratio of implementing, maintaining and understanding this feature isn't it worth.

Final decision is up to @korelstar of course.

@jotoeri
Copy link
Member Author

jotoeri commented Jan 23, 2021

why can't i create a note without a category?

Hm, how about everything without category goes to the current default Notes folder?

effort to decide what happens to the notes

Just keep the current Notes-Folder where it is and include it as atm?
-> In fact, one would just add new categories, having a different path than Notes/Category. Needs of course to store (and use) a specific path per category.

several working workarounds

Depends on if you accept as workaround, what is slow (and strange - instance uses outside interface to request data from itself?!) or one, which requires ssh root access?

@korelstar
Copy link
Member

This is related to #285, since your motivation is the same (managing shared notes). However, I think sharing categories from within the app (as discussed in #285) would be more advantageous than mapping categories to folders outside the notes directory after sharing them outside of the app. Hence, I agree with @stefan-niedermann , that your approach is rather complicated. I think, we should concentrate on implementing a sharing feature in the notes app itself.

For the meantime, there is a workaround:

Another way would be to share a folder inside the notes folder to your group and let every user move that shared folder from their root directory to their notes folder. That's the way I'm using notes in order to have both: a shared folder and my own notes.

@stefan-niedermann
Copy link
Member

Hm, how about everything without category goes to the current default Notes folder?

What do you do when the user tries to create a subcategorie in the Notes folder with the same name as a mounted folder?

Just keep the current Notes-Folder where it is and include it as atm?

How do you handle conflicts? Given a category ABC exists and the user wants to mount a folder ABC?

One dialog per scenario? Automatic decisions? How to teach the user whats happening?

There are so many pitfalls abd scenarions ... It ain't that easy as you mught imagine and the requeats for this exact issue seem to be quite little (you are the first - out of many thousand users) - so I still think the ratio of effort/complication and benefit is not enough at the moment.

@stefan-niedermann
Copy link
Member

Let's focus on #285 🙂 🚀

@jotoeri
Copy link
Member Author

jotoeri commented Jan 24, 2021

since your motivation is the same (managing shared notes).

Hm, actually sharing categories within the notes folder i do with groupfolders currently. That is quite easy to do.
Motivation was more to have project-notes within an existing folder-structure (sorted by project/sub-project, everything per project within respecitve folder), but for users to be able to use the notes app instead of the text-app for editing.

It ain't that easy as you mught imagine

Sorry, but that sounds to me like a high horse you are speaking from towards me. 👎 Let's keep discussions at eye level.

Anyways. I see this issue is done. 😢

@stefan-niedermann
Copy link
Member

I hit the wrong button, sorry 😄 Not my repository here, wasn't my intention to close it.

@stefan-niedermann
Copy link
Member

stefan-niedermann commented Jan 24, 2021

Sorry, but that sounds to me like a high horse you are speaking from towards me.

Also didn't want to sound rude, i just think that there are lots of edge cases and pitfalls which you might not have considered yet.

We can't just push a new feature in when there are so many questions left. And one of the questions (besides the already mentioned once is: Is this feature food for the majority of users or will it make things more complicated to satisfy a requirement which has never before been reported by anyone?

Let's keep discussions at eye level.

Well, we are a small team of volunteers and have to maintain and test this stuff, also in the future. This is not a one-shot for us and i want you to understand why we need discussions before adding new stuff. This has nothing to do with a "high horse" or "eye level".

But let's not get off topic. This is about your feature request, there are questiony left, i have spoken out my personal concerns and a decision has to be made (eventually by @korelstar )

@cdelledonne
Copy link

However that brought me to another workaround of a symlink on the server, which indeed requires root access, but is much faster than external storage.

@jotoeri I just stumbled upon this issue. What is this workaround you have found? Symlink'ing a folder on the server doesn't seem to result in anything on the client side.

Thank you in advance :)

@jotoeri
Copy link
Member Author

jotoeri commented Sep 12, 2021

Hm, @cdelledonne,
what do you mean with the client? The Notes-App on the Browser or the notes android-client?
I think i that once symlinked a folder via ssh into the notes folder within the users data-storage. Might need to reread the folder-structure via occ to take effect on the notes app on the browser. About the android-client i don't know how it operates, so i also can't tell you if the workaround will take effect there... 🤷‍♂️ 🤔

@cdelledonne
Copy link

Ah, re-scanning the file database with occ worked indeed. Thanks!

@thiswillbeyourgithub

This comment was marked as off-topic.

@stefan-niedermann

This comment was marked as off-topic.

@silopolis
Copy link

actually sharing categories within the notes folder i do with groupfolders currently.

Hi, can you roughy explain how you do this please?

@juliushaertl juliushaertl added enhancement New feature or request and removed feature request Requests for complete new features labels Jul 20, 2023
@Nawrux
Copy link

Nawrux commented Oct 4, 2023

What do you do when the user tries to create a subcategorie in the Notes folder with the same name as a mounted folder?

Only the mounted folder is used and if no mounted folder is set the default is being used

@Tinqerer
Copy link

Have others found a way to make this work? It'd be so good to have access to notes I keep organised in other folders, not just in the "Notes" folder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request needs discussion Need to clarify if and how we should implement this
Projects
None yet
Development

No branches or pull requests

9 participants