-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NC26 Browser Popup when leaving Notes App whitin a note #987
Comments
I can confirm it with Nextcloud 25 and Notes app 4.7.1 (debain 11, nginx, php 8.2, mysql) Edit: But I have to be fast enough, otherwise autosave triggers first Suggestion: Lines 339 to 343 in 6dca9d7
|
This is a browser limitation as it is not guaranteed that any requests performed during the before unload event are handled. This event is explicitly only for asking for confirmation. As far as I'm aware there is no way we can ensure that the file would be saved before navigating away except blocking with this dialog. |
why did it worked on nc25? |
furthermore if i just stay on an note it appears while changing the nc site |
What do you mean with "it worked" ? For me (on nc25 and nc26) it behaves as followed:
In other words (like the code in my comment showed #987 (comment) ): |
i did never get an popup on latest nc25 with the latest notes app on realease date of nc26 before upgrading to nc26. this behaviour is new, the environment (server nginx etc did not changed) |
Do you use the plain markdown or the rich editing view? For the plain markdown the logic shouldn't have changed at all from 25. |
same behaviour on both methods. |
Relates to #1008 with NC 26 |
Please make a clear and concise description of what the bug is. Please note, that issues with the Android app have to be reported under https://github.com/stefan-niedermann/nextcloud-notes/issues and issues with Nextcloud's Text app have to be reported under https://github.com/nextcloud/text/issues .
Steps to reproduce
1.open notes and write a note
2. click on files app or another
3. browser popup appears whit hint unsafed data gets lost
Expected behaviour
Data is safed
Actual behaviour
Tell us what happens instead
Screenshots
If applicable, add screenshots to help explain your problem.
Server
Please complete the following information.
Nextcloud configuration:
Client
Please complete the following information.
Log files
Add relevant parts of your
nextcloud.log
and/or your browser's JavaScript console here.The text was updated successfully, but these errors were encountered: