-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sidebar: removed #1004
Sidebar: removed #1004
Conversation
Glad to see so many awesome contributions @jonnytischbein I'll probably only get to review at the end of this week, but I try to go through them as soon as possible. |
So currently the app navigation actions menu does not offer a way to set the category just to navigate to it, which is something we'd need to address differently if we drop the sidebar. (#970) We don't have any outline yet how that could look like, so if you would have any suggestion for that UI wise we should discuss that first. Otherwise maybe @nimishavijay or @jancborchardt have more input for how the category could be selected in the navigation. |
My suggestion would be to move the Category dropdown menu from the sidebar to I can try to implement that in a bit |
I did another mockup, but still keep to figure out how to adjust the appearance of the menu item:
|
8944561
to
c76c689
Compare
Took the liberty to rebase this PR :) |
Signed-off-by: Jonathan Pagel <jonny_tischbein@systemli.org>
c76c689
to
4fffe35
Compare
I also further pushed a commit to include #1104 and making use of NcActionInput multiselect for switching the category. The overflow is not the nicest there yet, but this is something that should probably be fixed upstream. |
4fffe35
to
9607704
Compare
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
9607704
to
32b4598
Compare
Following #967 I removed the sidebar, because the only remaining function category can also be accessed via the app navigation. Also the sidebar isn't accessable in the richtext editor anyways.