Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Proper response for attachment endpoint #1031

Merged
merged 1 commit into from
May 5, 2023

Conversation

juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Apr 26, 2023

Use a stream response to set a Content-Disposition header on the attachments

@juliusknorr juliusknorr added the bug Something isn't working label Apr 26, 2023
@juliusknorr juliusknorr force-pushed the enh/attachment-response branch from 352ef7d to 084c052 Compare April 27, 2023 07:02
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr juliusknorr force-pushed the enh/attachment-response branch from 084c052 to d69517a Compare April 27, 2023 07:03
@juliusknorr juliusknorr requested a review from blizzz May 3, 2023 11:54
Copy link

@datenangebot datenangebot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codereview: looks good to me

@juliusknorr juliusknorr merged commit eb5c3ac into master May 5, 2023
@juliusknorr juliusknorr deleted the enh/attachment-response branch May 5, 2023 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants