Add bidi support #1191
Merged
Add bidi support #1191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mostafa Ahangarha <ahangarha@riseup.net>
Signed-off-by: Mostafa Ahangarha <ahangarha@riseup.net>
luka-nextcloud
approved these changes
Dec 29, 2023
|
Thanks so much for this contribution @ahangarha |
|
Thanks for your review and merge. Is there any particular reason to stick to a markdown editor based on codemirror? I am unsure how long it would take for codemirror to add bidi support. If not, I think there are good, viable options to consider. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a part of a series of PRs to the NextCloud ecosystem to add bidirectional text support.
In terms of the overall layout, this PR doesn't make any changes in the UI in LTR language (and in the current state of the NextCloud server for RTL language). But it brings flexibility to the UI so that in the RTL layout, it makes automatic adjustments.
Since the editor is a third-party package, adding bidi support to it will take longer time. We might even consider other options as codemirror failed in adding bidi support for a long time. But for the Preview, I added
markdown-it-bidiwhich is working fine now.Screenshot (in RTL layout)