Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add SPDX headers #1360

Merged
merged 1 commit into from
Sep 18, 2024
Merged

feat: add SPDX headers #1360

merged 1 commit into from
Sep 18, 2024

Conversation

luka-nextcloud
Copy link
Contributor

@luka-nextcloud luka-nextcloud commented Sep 10, 2024 •
edited
Loading

Resolves: #1325

@luka-nextcloud luka-nextcloud self-assigned this Sep 10, 2024
@juliushaertl
Copy link
Member

juliushaertl commented Sep 11, 2024 •
edited by luka-nextcloud
Loading

We also need:

juliushaertl
juliushaertl reviewed Sep 11, 2024
View reviewed changes
appinfo/routes.php Outdated Show resolved Hide resolved
AndyScherzinger
AndyScherzinger reviewed Sep 13, 2024
View reviewed changes
appinfo/info.xml Outdated Show resolved Hide resolved
@AndyScherzinger
Copy link
Member

Changes look good to me reuse/spdx-wise. Just 2 minor comments else 👍

@luka-nextcloud @AndyScherzinger
feat: add SPDX headers
2465c75 
Signed-off-by: Luka Trovic <luka@nextcloud.com>
@AndyScherzinger AndyScherzinger merged commit 4b3d4d5 into main Sep 18, 2024
8 of 10 checks passed
@AndyScherzinger AndyScherzinger deleted the feat/add-SPDX-headers branch September 18, 2024 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes

@juliushaertl juliushaertl juliushaertl approved these changes

Assignees

@luka-nextcloud luka-nextcloud

Labels
3. to review
Projects
📝 Office team
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add SPDX headers
3 participants
@luka-nextcloud @juliushaertl @AndyScherzinger