Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Adjust note item size to be one line #1387

Merged
merged 1 commit into from
Oct 11, 2024
Merged

Conversation

juliushaertl
Copy link
Member

@juliushaertl juliushaertl commented Oct 10, 2024

Otherwise lines are too large with the new more compact design

Before After
Screenshot 2024-10-10 at 16 52 23 Screenshot 2024-10-10 at 16 52 32

Fixes #1383

Signed-off-by: Julius Knorr <jus@bitgrid.net>
@juliushaertl juliushaertl added bug Something isn't working design Related to the design or user experience 3. to review labels Oct 10, 2024
Copy link

@enjeck enjeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool

@enjeck
Copy link

enjeck commented Oct 10, 2024

Btw, I notice the unrelated lint issues. Do we always just ignore those?

@juliushaertl
Copy link
Member Author

Not intentionally, I pushed #1389 to standardize the ci checks a bit and make them pass again

@juliushaertl juliushaertl merged commit 7f1cebf into main Oct 11, 2024
7 of 10 checks passed
@juliushaertl juliushaertl deleted the fix/note-item-height branch October 11, 2024 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review bug Something isn't working design Related to the design or user experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Too much wasted space in list of notes
2 participants