Update table style #878
Merged
Update table style #878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Felix Nüsse <felix.nuesse@t-online.de>
Signed-off-by: Felix Nüsse <felix.nuesse@t-online.de>
|
Could you please add some screenshots? (Before and after) |
The green tint is the hover-effect, similar to how text/collectives does it. |
Signed-off-by: Felix Nüsse <felix.nuesse@t-online.de>
korelstar
added
feature: Markdown-it
korelstar
requested changes
Jul 11, 2022
|
@korelstar sorry, what suggestion? Edit: My tests revealed that 0.75 em as padding works good. |
Signed-off-by: Felix Nüsse <felix.nuesse@t-online.de>
Sorry, my suggestion was lost (don't know why).
This is too much from my perspective. I did a little adjustment and I think it's ready to merge, now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Felix Nüsse felix.nuesse@t-online.de
This uses a more modern table layout, inspired by the collectives app.
Also thanks to Dai on Stackoverflow for the table-workaround!