Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove SCSS #927

Merged
merged 1 commit into from
Oct 3, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions css/global.css
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
.icon-notes {
background-image: url(../img/notes-dark.svg);
filter: var(--background-invert-if-dark);
}

.icon-notes-trans {
background-image: url(../img/notes-trans.svg);
filter: var(--background-invert-if-dark);
}

2 changes: 0 additions & 2 deletions css/global.scss

This file was deleted.

48 changes: 31 additions & 17 deletions css/app-navigation.scss → css/notes.css
Original file line number Diff line number Diff line change
@@ -1,3 +1,10 @@
/* workaround for https://github.com/nextcloud/nextcloud-vue/issues/1384 */
body {
min-height: 100%;
height: auto;
}

/* App Navigation fixes */
.app-navigation-entry.category-header:not(.app-navigation-entry--opened) .app-navigation-entry__title {
font-weight: bold;
}
Expand All @@ -7,23 +14,6 @@
pointer-events: inherit;
}

#app-navigation > ul > li.app-navigation-caption.timeslot {
color: var(--color-text-maxcontrast);
}

/* icons for sidebar */
.icon-files {
@include icon-color('folder', 'notes', $color-black);
}

.icon-emptyfolder {
@include icon-color('folder-empty', 'notes', $color-black);
}

.icon-recent {
@include icon-color('recent', 'notes', $color-black);
}

.app-navigation-entry__utils .action-item {
visibility: hidden;
}
Expand All @@ -36,3 +26,27 @@ li:focus .app-navigation-entry__utils .action-item {
visibility: visible;
}

@media print {
#header,
.app-navigation,
#note-container .action-buttons,
#note-container .upload-button {
display: none !important;
}

.content {
display: block;
padding: 0;
color: #000;
}

#note-container .note-editor,
#note-container .note-preview {
padding: 0 !important;
font-size: 10pt !important;
}

.app-content {
margin-left: 0 !important;
}
}
8 changes: 0 additions & 8 deletions css/notes.scss

This file was deleted.

23 changes: 0 additions & 23 deletions css/print.scss

This file was deleted.

1 change: 0 additions & 1 deletion img/folder-empty.svg

This file was deleted.

1 change: 0 additions & 1 deletion img/folder.svg

This file was deleted.

1 change: 1 addition & 0 deletions img/notes-dark.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion img/notes-trans.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
1 change: 0 additions & 1 deletion img/recent.svg

This file was deleted.

2 changes: 1 addition & 1 deletion src/components/Dashboard.vue
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ export default {
}

.note-item-favorite {
background: var(--icon-star-dark-FC0, var(--icon-star-dark-fc0));
background: var(--icon-starred-yellow, var(--icon-star-dark-FC0, var(--icon-star-dark-fc0)));
}

.note-item {
Expand Down
22 changes: 19 additions & 3 deletions src/components/NavigationCategoriesItem.vue
Original file line number Diff line number Diff line change
@@ -1,18 +1,18 @@
<template>
<AppNavigationItem
:title="title"
icon="icon-files"
class="app-navigation-noclose separator-below"
:class="{ 'category-header': selectedCategory !== null }"
:open.sync="open"
:allow-collapse="true"
@click.prevent.stop="onToggleCategories"
>
<FolderIcon slot="icon" :size="20" fill-color="var(--color-main-text)" />
<AppNavigationItem
:title="t('notes', 'All notes')"
icon="icon-recent"
@click.prevent.stop="onSelectCategory(null)"
>
<HistoryIcon slot="icon" :size="20" fill-color="var(--color-main-text)" />
<AppNavigationCounter slot="counter">
{{ numNotes }}
</AppNavigationCounter>
Expand All @@ -21,9 +21,18 @@
<AppNavigationItem v-for="category in categories"
:key="category.name"
:title="categoryTitle(category.name)"
:icon="category.name === '' ? 'icon-emptyfolder' : 'icon-files'"
@click.prevent.stop="onSelectCategory(category.name)"
>
<FolderOutlineIcon v-if="category.name === ''"
slot="icon"
:size="20"
fill-color="var(--color-main-text)"
/>
<FolderIcon v-else
slot="icon"
:size="20"
fill-color="var(--color-main-text)"
/>
<AppNavigationCounter slot="counter">
{{ category.count }}
</AppNavigationCounter>
Expand All @@ -37,6 +46,10 @@ import {
AppNavigationCounter,
} from '@nextcloud/vue'

import FolderIcon from 'vue-material-design-icons/Folder.vue'
import FolderOutlineIcon from 'vue-material-design-icons/FolderOutline.vue'
import HistoryIcon from 'vue-material-design-icons/History.vue'

import { getCategories } from '../NotesService.js'
import { categoryLabel } from '../Util.js'
import store from '../store.js'
Expand All @@ -47,6 +60,9 @@ export default {
components: {
AppNavigationItem,
AppNavigationCounter,
FolderIcon,
FolderOutlineIcon,
HistoryIcon,
},

props: {
Expand Down
1 change: 0 additions & 1 deletion src/components/NavigationList.vue
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
<template v-for="item in noteItems">
<AppNavigationCaption v-if="category!==null && category!==item.category"
:key="item.category"
icon="icon-files"
class="app-navigation-noclose"
:title="categoryToLabel(item.category)"
@click.native="$emit('category-selected', item.category)"
Expand Down
28 changes: 23 additions & 5 deletions src/components/Note.vue
Original file line number Diff line number Diff line change
Expand Up @@ -51,26 +51,36 @@
icon="icon-details"
@click="onToggleSidebar"
>
<SidebarIcon slot="icon" :size="20" fill-color="var(--color-main-text)" />
{{ t('notes', 'Details') }}
</ActionButton>
<ActionButton
v-tooltip.left="t('notes', 'CTRL + /')"
:icon="preview ? 'icon-rename' : 'icon-toggle'"
@click="onTogglePreview"
>
<EditIcon v-if="preview"
slot="icon"
:size="20"
fill-color="var(--color-main-text)"
/>
<EyeIcon v-else
slot="icon"
:size="20"
fill-color="var(--color-main-text)"
/>
{{ preview ? t('notes', 'Edit') : t('notes', 'Preview') }}
</ActionButton>
<ActionButton
icon="icon-fullscreen"
:class="{ active: fullscreen }"
@click="onToggleDistractionFree"
>
<FullscreenIcon slot="icon" :size="20" fill-color="var(--color-main-text)" />
{{ fullscreen ? t('notes', 'Exit full screen') : t('notes', 'Full screen') }}
</ActionButton>
</Actions>
<Actions v-if="note.readonly">
<ActionButton>
<PencilOffIcon slot="icon" :size="20" fill-color="var(--color-main-text)" />
<NoEditIcon slot="icon" :size="20" fill-color="var(--color-main-text)" />
{{ t('notes', 'Note is read-only. You cannot change it.') }}
</ActionButton>
</Actions>
Expand Down Expand Up @@ -103,8 +113,12 @@ import {
import { showError } from '@nextcloud/dialogs'
import { emit } from '@nextcloud/event-bus'

import EditIcon from 'vue-material-design-icons/LeadPencil.vue'
import EyeIcon from 'vue-material-design-icons/Eye.vue'
import FullscreenIcon from 'vue-material-design-icons/Fullscreen.vue'
import NoEditIcon from 'vue-material-design-icons/PencilOff.vue'
import SidebarIcon from 'vue-material-design-icons/PageLayoutSidebarRight.vue'
import SyncAlertIcon from 'vue-material-design-icons/SyncAlert.vue'
import PencilOffIcon from 'vue-material-design-icons/PencilOff.vue'

import { config } from '../config.js'
import { fetchNote, refreshNote, saveNoteManually, queueCommand, conflictSolutionLocal, conflictSolutionRemote } from '../NotesService.js'
Expand All @@ -122,8 +136,12 @@ export default {
ActionButton,
AppContent,
ConflictSolution,
EditIcon,
EyeIcon,
FullscreenIcon,
Modal,
PencilOffIcon,
NoEditIcon,
SidebarIcon,
SyncAlertIcon,
TheEditor,
ThePreview,
Expand Down
15 changes: 13 additions & 2 deletions src/components/Sidebar.vue
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,15 @@
@close="onCloseSidebar"
>
<div class="sidebar-content-wrapper">
<div v-if="!note.readonly" class="note-category" :title="t('notes', 'Set category')">
<h4>{{ t('notes', 'Category') }} <span v-tooltip="categoriesInfo" class="icon-info svg" /></h4>
<div v-if="!note.readonly" class="note-category">
<h4>
{{ t('notes', 'Category') }}
<InfoIcon v-tooltip="categoriesInfo"
:size="20"
fill-color="var(--color-main-text)"
style="display: inline-block; margin-left: 1ex;"
/>
</h4>
<form class="category" @submit.prevent.stop="">
<Multiselect id="category"
:value="category"
Expand All @@ -20,6 +27,7 @@
:show-no-results="false"
:taggable="true"
:preserve-search="true"
:title="t('notes', 'Set category')"
@input="onSaveCategory"
@close="onFinishEditCategory"
@search-change="onEditCategory"
Expand Down Expand Up @@ -61,6 +69,8 @@ import {
} from '@nextcloud/vue'
import moment from '@nextcloud/moment'

import InfoIcon from 'vue-material-design-icons/Information.vue'

import { getCategories, setFavorite, setCategory, saveNoteManually } from '../NotesService.js'
import { categoryLabel } from '../Util.js'
import store from '../store.js'
Expand All @@ -70,6 +80,7 @@ export default {

components: {
AppSidebar,
InfoIcon,
Multiselect,
},

Expand Down