Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix asterix conflict with talk #1028

Merged
merged 1 commit into from
Jun 21, 2021

Conversation

nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Jun 21, 2021

Reverse of nextcloud/spreed#5831

Simplifying the logic a bit

Steps

  1. Open Talk
  2. Before the room list finished loading open another tab
  3. Check that Talk marks the tab with * already, otherwise write a message in a channel where this user is a member of
  4. Trigger a notification: occ notification:generate

Before

* * …

After

* …

Signed-off-by: Joas Schilling <coding@schilljs.com>
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81
Copy link
Member

with time passing, I find more and more that it would be convenient to only have a single channel for all possible notifications, updates, messages,

@nickvergessen
Copy link
Member Author

I was also thinking about a lib which apps just tell it should yield the asterix, use a new base page title, etc and the lib itself unmarks the asterix when the page is opened again. So no one has to worry about anything.

@nickvergessen nickvergessen merged commit 843d47e into master Jun 21, 2021
@nickvergessen nickvergessen deleted the bugfix/noid/fix-asterix-conflict-with-talk branch June 21, 2021 18:07
@blizzz blizzz mentioned this pull request Jun 23, 2021
39 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants