Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace custom tooltips with native ones. #1430

Merged
merged 1 commit into from
Jan 27, 2023
Merged

Replace custom tooltips with native ones. #1430

merged 1 commit into from
Jan 27, 2023

Conversation

JuliaKirschenheuter
Copy link
Contributor

@JuliaKirschenheuter JuliaKirschenheuter commented Jan 26, 2023 •
edited
Loading

Replace custom tooltips with native ones. Remove "vue-tooltip" from project.

Fixes #1410

ToDo:

  • Add additional visual-hidden <span> for date

@JuliaKirschenheuter JuliaKirschenheuter self-assigned this Jan 26, 2023
@JuliaKirschenheuter JuliaKirschenheuter force-pushed the fix/1410-Replace_custom_tooltips_with_native_one branch from 287888c to 21d55cc Compare January 26, 2023 11:06
@JuliaKirschenheuter JuliaKirschenheuter marked this pull request as ready for review January 26, 2023 13:29
@JuliaKirschenheuter JuliaKirschenheuter marked this pull request as draft January 26, 2023 14:15
@JuliaKirschenheuter JuliaKirschenheuter marked this pull request as ready for review January 26, 2023 14:29
@JuliaKirschenheuter @nickvergessen
Replace custom tooltips with native ones. Remove "vue-tooltip" from p…
80697c9 
…roject.

Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>
@nickvergessen nickvergessen force-pushed the fix/1410-Replace_custom_tooltips_with_native_one branch from 259690f to 80697c9 Compare January 27, 2023 09:50
nickvergessen
nickvergessen approved these changes Jan 27, 2023
View reviewed changes
src/Components/Notification.vue
<span v-if="timestamp"
v-tooltip.bottom="absoluteDate"
:title="absoluteDate"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bildschirmfoto vom 2023-01-27 10-49-40

Works

src/Components/Parameters/File.vue
@@ -20,21 +20,16 @@
-->

<template>
<a v-tooltip.bottom="title"
<a :title="title"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works
Bildschirmfoto vom 2023-01-27 10-49-47

@nickvergessen
Copy link
Member

Rebased to get #1433 and other CI prs in, so it is green in the end

@nickvergessen nickvergessen merged commit 326de70 into master Jan 27, 2023
@nickvergessen nickvergessen deleted the fix/1410-Replace_custom_tooltips_with_native_one branch January 27, 2023 09:58
@JuliaKirschenheuter
Copy link
Contributor Author

/backport to stable25

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Jan 30, 2023
Merged
1 task
@blizzz blizzz mentioned this pull request Feb 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@artonge artonge artonge approved these changes

@Pytal Pytal Pytal approved these changes

Assignees

@JuliaKirschenheuter JuliaKirschenheuter

Labels
3. to review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BITV] Replace custom tooltips with native one
4 participants
@JuliaKirschenheuter @nickvergessen @artonge @Pytal