-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix header icon accessibility #146
Conversation
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
Ready to review together with the server pull request at nextcloud/server#10310 :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The notifications icon was usable before, but this improves things a great deal. The markup appears to have everything i could hope for, of course, someone must comment on the css changes.
Btw @tyrylu did I invite you to the Nextcloud Conference in Berlin already? :) There's travel & hotel support for contributors, apply soon! All infos at https://nextcloud.com/conf/ |
You in fact did not, however because of my visual impairments i would need to find very likely someone to travel with me and i am not aware of anyone i could talk into this. The possibility sounds wonderful and getting to the place from the Czech republic would be relatively easy, but some friend as a guide would be much appreciated, so currently i doubt my attendance. Are any video recordings planned? |
@tyrylu we will have video recording for the talks, yes... I'm sorry, I can't tell you if there are others coming from CZ who could help you get to Berlin 😞 |
Thank you. |
@tyrylu ok, so we can keep that in mind for next year maybe? :) The conference is annually and it would be great to have you some time. Since the Czech Republic is also quite nearby, if you do have a person who can accompany you we could also work that out with travel support for the other person as well. But in any case it’s great to have you in the community! :) |
We could, definitely. I don't have much friends who a. would be at least partially interested in this conference and b. have time, but i hope i can sort something out. And, of course, thank you. |
Related server pull request: nextcloud/server#10310 cc @nextcloud/accessibility :)