Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix header icon accessibility #146

Merged
merged 1 commit into from
Jul 25, 2018
Merged

Fix header icon accessibility #146

merged 1 commit into from
Jul 25, 2018

Conversation

jancborchardt
Copy link
Member

@jancborchardt jancborchardt commented Jul 20, 2018

  • Fix opening on enter when focused

Related server pull request: nextcloud/server#10310 cc @nextcloud/accessibility :)

Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
@jancborchardt
Copy link
Member Author

Ready to review together with the server pull request at nextcloud/server#10310 :)

Copy link

@tyrylu tyrylu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The notifications icon was usable before, but this improves things a great deal. The markup appears to have everything i could hope for, of course, someone must comment on the css changes.

@nickvergessen nickvergessen merged commit 09f7063 into master Jul 25, 2018
@nickvergessen nickvergessen deleted the accessibility-header branch July 25, 2018 10:21
@jancborchardt
Copy link
Member Author

jancborchardt commented Jul 26, 2018

Btw @tyrylu did I invite you to the Nextcloud Conference in Berlin already? :) There's travel & hotel support for contributors, apply soon! All infos at https://nextcloud.com/conf/

@tyrylu
Copy link

tyrylu commented Jul 26, 2018

You in fact did not, however because of my visual impairments i would need to find very likely someone to travel with me and i am not aware of anyone i could talk into this. The possibility sounds wonderful and getting to the place from the Czech republic would be relatively easy, but some friend as a guide would be much appreciated, so currently i doubt my attendance. Are any video recordings planned?

@jospoortvliet
Copy link
Member

@tyrylu we will have video recording for the talks, yes... I'm sorry, I can't tell you if there are others coming from CZ who could help you get to Berlin 😞

@tyrylu
Copy link

tyrylu commented Jul 27, 2018

Thank you.

@jancborchardt
Copy link
Member Author

@tyrylu ok, so we can keep that in mind for next year maybe? :) The conference is annually and it would be great to have you some time. Since the Czech Republic is also quite nearby, if you do have a person who can accompany you we could also work that out with travel support for the other person as well.

But in any case it’s great to have you in the community! :)

@tyrylu
Copy link

tyrylu commented Jul 30, 2018

We could, definitely. I don't have much friends who a. would be at least partially interested in this conference and b. have time, but i hope i can sort something out. And, of course, thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants