fix(style): clear excessive and redundant styles #2128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Antreesy
commented
Dec 23, 2024
•
Antreesy
commented
- remove redundant styles (most comes from vue-library already)
- move rest to SFC file
- ease template (extra div)
| Before | After |
|---|---|
 |
 |
- move from separate file to component Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
|
/compile / |
ShGKme
reviewed
Dec 23, 2024
|
If there was a confusion with dialog 'Close' icon, maybe this would be enough to distinct? I'm also up for some minor change instead of using 'Delete' icon https://pictogrammers.com/library/mdi/icon/close-circle-outline/ |
nickvergessen
previously requested changes
Dec 24, 2024
Antreesy
force-pushed
the
fix/1718/notifications-style
branch
from
4977a2c to
d886223
Compare
|
/compile / |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
ShGKme
approved these changes
Dec 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.