Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Nextcloud 16 polishing #300

Merged
merged 8 commits into from
Mar 18, 2019
Merged

Conversation

nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Mar 12, 2019

  • Add eslint with the same rules as in other apps

  • Dismissing older notification also hides every newer notification (only until refresh)
  • Notifications window should have min-height (same as when it’s empty)
  • Needs short compress animation for dismissing for proper feedback

@nickvergessen
Copy link
Member Author

Needs short compress animation for dismissing for proper feedback

Can a @nextcloud/javascript do this or tell me how? I guess it goes here and fade is not enough/working?

// this._$el.fadeOut(OC.menuSpeed);

Dismissing older notification also hides every newer notification (only until refresh)

Although the logic is the same as in all other apps I used Vue in until now, index is undefined in

onRemove: function(index) {
removing always the first item, so when you delete teh second one of two, the list shows nothing anymore.

@MorrisJobke
Copy link
Member

removing always the first item, so when you delete teh second one of two, the list shows nothing anymore.

FYI: Having 3 notifications then deleting the second results in a list with only the third one.

@nickvergessen
Copy link
Member Author

@skjnldsv

  • Fixed position of empty content
  • Transition in chromium on last removal

@skjnldsv
Copy link
Member

DOne

src/App.vue Outdated Show resolved Hide resolved
src/init.js Show resolved Hide resolved
@nickvergessen nickvergessen requested a review from skjnldsv March 14, 2019 13:23
src/App.vue Outdated Show resolved Hide resolved
src/App.vue Outdated Show resolved Hide resolved
@nickvergessen nickvergessen force-pushed the feature/noid/nc16-polishing branch from 2d9c08e to 77a204d Compare March 15, 2019 10:45
nickvergessen and others added 8 commits March 18, 2019 11:12
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen force-pushed the feature/noid/nc16-polishing branch from bd5de24 to f1f6a55 Compare March 18, 2019 10:14
@nickvergessen nickvergessen merged commit 0afac0f into master Mar 18, 2019
@nickvergessen nickvergessen deleted the feature/noid/nc16-polishing branch March 18, 2019 10:35
@MorrisJobke MorrisJobke mentioned this pull request Mar 20, 2019
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants