-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Nextcloud 16 polishing #300
Conversation
nickvergessen
commented
Mar 12, 2019
•
edited
Loading
edited
- Add eslint with the same rules as in other apps
- Dismissing older notification also hides every newer notification (only until refresh)
- Notifications window should have min-height (same as when it’s empty)
- Needs short compress animation for dismissing for proper feedback
Can a @nextcloud/javascript do this or tell me how? I guess it goes here and fade is not enough/working? notifications/src/components/Notification.vue Line 213 in c349dcc
Although the logic is the same as in all other apps I used Vue in until now, index is undefined in Line 118 in c349dcc
|
FYI: Having 3 notifications then deleting the second results in a list with only the third one. |
|
DOne |
2d9c08e
to
77a204d
Compare
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
bd5de24
to
f1f6a55
Compare