move push_notify logic to a js library #837
Merged
+5,811
−57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icewind1991
force-pushed
the
notify_push-lib
branch
from
49b798d to
9ae8db6
Compare
|
/compile amend / |
npmbuildbot-nextcloud
bot
force-pushed
the
notify_push-lib
branch
from
9ae8db6 to
bf85a07
Compare
rullzer
force-pushed
the
notify_push-lib
branch
from
bf85a07 to
3997c73
Compare
|
/compile amend / |
Signed-off-by: Robin Appelman <robin@icewind.nl> Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
npmbuildbot-nextcloud
bot
force-pushed
the
notify_push-lib
branch
from
3997c73 to
e6aee7d
Compare
rullzer
approved these changes
Jan 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This not only moves the socket management to a reusable library but also allows multiple apps to re-use the same socket.
Library code is at https://github.com/icewind1991/notify_push-client for now