feat(Dockerfile): switch cmd to entrypoint #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alerque
approved these changes
Aug 7, 2021
Pytal
approved these changes
Aug 9, 2021
|
@SimJoSt checks require a signoff :) git commit --amend --no-edit --signoff
git push --force-with-lease origin feat/Dockerfile/switch-cmd-to-entrypoint |
|
The problem with changing that now is that it would break all existing setups that use the existing CMD overwrite |
True, I do still think this is a good Docker standard to follow though :) Should we reconsider this when we near 1.0? |
icewind1991
force-pushed
the
main
branch
2 times, most recently
from
87ee088
to
10d0f15
Compare
By using `ENTRYPOINT` for the default command, it is possible to extend the command with arguments by using `CMD` in a custom Dockerfile. As the command itself doesn't need to be changed/overwritten with this approach, changes to the location of the binary or command will not break these configurations in the future. Signed-off-by: Joda Stößer <git@simjo.st>
SimJoSt
force-pushed
the
feat/Dockerfile/switch-cmd-to-entrypoint
branch
from
59e9e72
to
baace31
Compare
Signed-off-by: Joda Stößer <git@simjo.st>
SimJoSt
force-pushed
the
feat/Dockerfile/switch-cmd-to-entrypoint
branch
from
55a63f1
to
167276c
Compare
|
@icewind1991 @Pytal @alerque I finally got a grip on all my PRs and updated this one as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By using
ENTRYPOINTfor the default command, it is possible to extend the command with arguments by usingCMDin a custom Dockerfile. As the command itself doesn't need to be changed/overwritten with this approach, changes to the location of the binary or command will not break these configurations in the future.