Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed remote redirect URL for federation shared files #523

Merged

Conversation

hopleus
Copy link
Contributor

@hopleus hopleus commented Feb 19, 2024

Summary

Fixed remote redirect URL for federation shared files

Use case:

After the file has been shared through the federation, it cannot be opened because the redirect URL is incorrect.

Example of a redirect URL:
it was:
https://domain.comindex.php/apps/officeonline/remote?shareToken =...
It became:
https://domain.com/apps/officeonline/remote?shareToken =...

Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits
  • Documentation (manuals or wiki) has been updated or is not required

@hopleus hopleus marked this pull request as draft February 19, 2024 12:29
@hopleus hopleus marked this pull request as ready for review February 19, 2024 12:29
Signed-off-by: hopleus <hopleus@gmail.com>
@hopleus hopleus force-pushed the bugfix/fix-redirect-url-federation-sharing branch from 2c758c3 to e4e0767 Compare February 19, 2024 13:28
@hopleus
Copy link
Contributor Author

hopleus commented Feb 29, 2024

@blizzz Hi. Could you run the tests?

lib/Service/FederationService.php Outdated Show resolved Hide resolved
@blizzz
Copy link
Member

blizzz commented Feb 29, 2024

@blizzz Hi. Could you run the tests?

Hi @hopleus, thanks for your contribution! I left a review, will approve when it is addressed :)

@hopleus hopleus requested a review from blizzz February 29, 2024 11:19
@hopleus hopleus force-pushed the bugfix/fix-redirect-url-federation-sharing branch from 1728611 to 6148b21 Compare February 29, 2024 11:22
@blizzz blizzz requested a review from juliusknorr February 29, 2024 13:20
@blizzz blizzz added 4. to release Ready to be released and/or waiting for tests to finish bug Something isn't working labels Feb 29, 2024
Copy link

github-actions bot commented Mar 5, 2024

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

@blizzz blizzz merged commit fe4262e into nextcloud:main Mar 11, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug Something isn't working feedback-requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants