Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support inline comments in types #10

Closed
provokateurin opened this issue Aug 18, 2023 · 4 comments · Fixed by #221
Closed

Support inline comments in types #10

provokateurin opened this issue Aug 18, 2023 · 4 comments · Fixed by #221
Assignees
@provokateurin
Labels
enhancement New feature or request

Comments

@provokateurin
Copy link
Member

vimeo/psalm#8168
@provokateurin provokateurin added the enhancement New feature or request label Aug 18, 2023
@provokateurin provokateurin changed the title Suppoet inline comments in types Support inline comments in types Aug 18, 2023
@provokateurin provokateurin mentioned this issue Jan 24, 2024
Closed
@provokateurin
Copy link
Member Author

Not possible at the moment because we use the phpstan doc parser which doesn't support the inline comments like psalm (see the linked issue above). Sadly psalm doesn't expose the parsing libraries separately so we can't use that either (vimeo/psalm#2094).

@provokateurin
Copy link
Member Author

The relevant phpdoc-parser issue is phpstan/phpdoc-parser#184. This feature can not be implemented without it.

@provokateurin
Copy link
Member Author

phpstan/phpdoc-parser#264 just got merged, so this is finally possible.

@provokateurin provokateurin self-assigned this Mar 4, 2025
@provokateurin provokateurin moved this to 📄 To do (~10 entries) in 📁 Files team Mar 4, 2025
@provokateurin
Copy link
Member Author

I just checked and with #214 being merged this feature can be implemented now, because the minimum version is 2.1.0!

@provokateurin provokateurin mentioned this issue Mar 5, 2025
Merged
@provokateurin provokateurin moved this from 📄 To do (~10 entries) to 🏗️ In progress in 📁 Files team Mar 5, 2025
@github-project-automation github-project-automation bot moved this from 🏗️ In progress to ☑️ Done in 📁 Files team Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@provokateurin provokateurin

Labels
enhancement New feature or request
Projects
📁 Files team
Status: ☑️ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(OpenApiType): Support comments in object array types nextcloud/openapi-extractor
1 participant
@provokateurin