feat(OpenApiType): Support comments in object array types #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: provokateurin <kate@provokateurin.de>
provokateurin
force-pushed
the
feat/openapitype/object-comments
branch
from
b759d54 to
bbfa4cb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10.
I also tried comments at the end of the line, but those are completely ignored and do not appear in the parser output. I'm not sure if this is a phpdoc-parser bug or not, but having the option to set any comments at all is much better than having it not.
Also adding comments in front of a type alias doesn't work either, so it's not possible yet to set the description of an entire schema.