Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate context of vendor folder and update PHPUnit package #469

Closed
wants to merge 2 commits into from
Closed

Separate context of vendor folder and update PHPUnit package #469

wants to merge 2 commits into from

Conversation

vitormattos
Copy link
Contributor

Initial improvements to implement #386

@vitormattos vitormattos added this to the Nextcloud 27 milestone May 15, 2023
@vitormattos vitormattos requested a review from nickvergessen May 15, 2023 23:07
@vitormattos vitormattos self-assigned this May 15, 2023
@vitormattos vitormattos force-pushed the feature/separate-context-of-vendor-folder branch from 6873301 to f2a2889 Compare May 15, 2023 23:09
nickvergessen
nickvergessen reviewed May 16, 2023
View reviewed changes
composer.json Outdated Show resolved Hide resolved
datenangebot
datenangebot approved these changes May 16, 2023
View reviewed changes
Copy link

@datenangebot datenangebot left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, smoke-test successful, CI green

Edit: Oh no, phpunit tests not successful.

@vitormattos vitormattos force-pushed the feature/separate-context-of-vendor-folder branch from 8fde723 to 28cd103 Compare May 16, 2023 10:37
@blizzz blizzz mentioned this pull request May 17, 2023
Merged
@blizzz blizzz modified the milestones: Nextcloud 27, Nextcloud 28 May 23, 2023
@datenangebot
Copy link

/rebase

@datenangebot datenangebot force-pushed the feature/separate-context-of-vendor-folder branch from 28cd103 to c06e7a9 Compare May 26, 2023 07:04
@datenangebot datenangebot enabled auto-merge May 26, 2023 07:04
@skjnldsv skjnldsv mentioned this pull request Nov 1, 2023
Merged
This was referenced Nov 6, 2023
Merged
Merged
vitormattos and others added 2 commits November 12, 2023 01:27
@vitormattos @susnux
Separate context of vendor folder and update PHPUnit package
3aff4b6 
Signed-off-by: Vitor Mattos <vitor@php.rio>
@nickvergessen @vitormattos @susnux
Update composer.json -> nextcloud/ocp
82aa4c2 
Co-authored-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com>
Signed-off-by: Florian <florian.steffens@nextcloud.com>
Co-authored-by: Vitor Mattos <vitor@php.rio>
@susnux susnux force-pushed the feature/separate-context-of-vendor-folder branch from c06e7a9 to 82aa4c2 Compare November 12, 2023 00:30
This was referenced Nov 14, 2023
Merged
Merged
@blizzz blizzz modified the milestones: Nextcloud 28, Nextcloud 29 Nov 23, 2023
This was referenced Mar 12, 2024
Merged
Merged
auto-merge was automatically disabled March 14, 2024 09:31

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen left review comments

@datenangebot datenangebot datenangebot approved these changes

Assignees

@vitormattos vitormattos

Labels
3. to review
Projects
None yet
Milestone
Nextcloud 29
Development

Successfully merging this pull request may close these issues.
4 participants
@vitormattos @datenangebot @nickvergessen @blizzz