feat: Allow to configure different policies per password context #717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
* Add support for multiple password policies (per context) * Split Vue files into components * Use Typescript (also for the script part of Vue files) Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
feat/support-password-context
branch
from
d87ea09 to
f3d9920
Compare
susnux
changed the title
juliusknorr
reviewed
Jan 20, 2025
| public function getMinLength(): int { | ||
| return max(0, $this->appConfig->getValueInt(Application::APP_ID, 'minLength', 10)); | ||
| public function getMinLength(?PasswordContext $context = null): int { | ||
| $key = $this->getScopedAppConfig('minLength', $context); |
There was a problem hiding this comment.
Do I get this right that there is now only the scoped policies and no longer one default policy? If we do that we should add a migration step for existing configs. Otherwise we could have a default policy and fall back to that if no custom one is configured
There was a problem hiding this comment.
That is what is done, if e.g. there is no policy for sharing the default one is applied.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The server already emits the events with password context information (new with Nextcloud 31), so this implements the support to configure different policies for different contexts.
For the reviewers: Please first check the backend stuff - if there is anything we need to adjust we should do this first before adjusting the frontend.
Summary
Possible improvement
Maybe it would be easier to make the server enum backed with the string value.
That would remove 2 functions here and make some functions easier.