Split all the validators #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skjnldsv
approved these changes
Aug 13, 2019
ChristophWurst
requested changes
Aug 26, 2019
| public function validate(string $password): bool { | ||
| $enforceNonCommonPassword = $this->config->getEnforceNonCommonPassword(); | ||
| if($enforceNonCommonPassword) { | ||
| $passwordFile = __DIR__ . '/../../lists/list-'.strlen($password).'.php'; |
There was a problem hiding this comment.
move the $passwordFile assigment one line up and combine the first two if's for better readibility
| ['banana', false, true], | ||
| ['bananabananabananabanana', false, true], | ||
| ['banana', true, false], | ||
| ['bananabananabananabanana', true, true], |
| @@ -66,7 +66,8 @@ public function testValidate(string $password, bool $enforced, bool $valid) { | |||
| $this->expectException(HintException::class); | |||
| } | |||
|
|
|||
| $this->assertTrue($this->validator->validate($password)); | |||
| $this->assertTrue(true); | |||
There was a problem hiding this comment.
Really? What if if fails?
There was a problem hiding this comment.
Well it either throws an exception or not.
The assert is there to ensure phpunit is quite about risky tests
There was a problem hiding this comment.
I was referring to a joke http://geek-and-poke.com/geekandpoke/2014/1/15/philosophising-geeks
ChristophWurst
approved these changes
Aug 27, 2019
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
rullzer
force-pushed
the
enh/split_into_validators
branch
from
4000ea6 to
776583e
Compare
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
rullzer
force-pushed
the
enh/split_into_validators
branch
from
776583e to
7d92b2c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleans it up a bit.