Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uploading files to an album does not work #1396

Closed
nicokaiser opened this issue Oct 19, 2022 · 8 comments · Fixed by #1782
Closed

Uploading files to an album does not work #1396

nicokaiser opened this issue Oct 19, 2022 · 8 comments · Fixed by #1782
Labels
0. Needs triage Pending approval or rejection. This issue is pending approval. bug Something isn't working needs info Not enough information provided

Comments

@nicokaiser
Copy link
Contributor

Describe the bug
Uploading files to an album does not seem to work.

To Reproduce
Steps to reproduce the behavior:

  1. Navigate to Albums
  2. Click on "+ New album"
  3. Set the Name of the album
  4. Click on "Create album"
  5. Click "+ Add"
  6. In the Popup, click "+ Add"
  7. Select files to add to the album

Photos are uploaded to the /Photos folder, but the album stays empty. The browser console does not show any error messages.

Expected behavior
I'd expect the uploaded photos to be added to the album.

Desktop (please complete the following information):

  • OS: macOS
  • Browser: Chrome

Server:
Nextcloud 25.0.0

@nicokaiser nicokaiser added 0. Needs triage Pending approval or rejection. This issue is pending approval. bug Something isn't working labels Oct 19, 2022
@skjnldsv
Copy link
Member

I will need a screenshot of your network requests.
Before you do anything, still on the development tools, there is a tab called network. Click on it and then the xhr filter. Do your action and screenshot the network log like this:
capture d ecran_2018-09-27_21-49-46

@skjnldsv skjnldsv added the needs info Not enough information provided label Oct 19, 2022
@nicokaiser
Copy link
Contributor Author

Bildschirmfoto 2022-10-19 um 19 35 09

Here is a screenshot. The upload of the two jpg files worked, but they do not appear in the album.

@skjnldsv
Copy link
Member

Yep, seems like there is a request missing.
The files gets uploaded in your Photos folder though, right?

@nicokaiser
Copy link
Contributor Author

The files gets uploaded in your Photos folder though, right?

Yes, correct.

@nicokaiser
Copy link
Contributor Author

(I only found this while looking for a convenient way to add many photos to an album. Since there is currently no way to select multiple photos, e.g. by Shift-clicking the last photo, I tried to upload them to an album directly... I'll add a separate feature-request for the multi-selection feature)

@Gordin508
Copy link

Gordin508 commented Jan 5, 2023

I also noticed this using Nextcloud version 25.0.2.

The problem is that the "Add photos to this album" dialog does not seem to get updated with new images uploaded through its "Add" option. When I reopen the dialog once, the newly added image is shown by name but the thumbnail is missing (error 500 for the ?x=64&y=64 thumbnail). Reopening it twice shows the newly added image. Switching to another page and back again also shows the image in the dialog.

Adding images to the album directly via "Add -> Upload Files" (top right corner) works as expected, but this option does not appear as long as the album is still empty. A possible temporary fix would be just omitting the special behavior for empty albums and always showing the "Add" menu which allows for direct upload?

Personally, I'd say that the dialog which allows you to pick from already uploaded photos should not have an upload functionality at all. Rather, the option to select already uploaded photos from the cloud and the option to upload additional photos should be kept as two separate functions with mutually exclusive features.

@bernardstef
Copy link

Hi ! Using Nextcloud 28.0.5 , this problem is still present

"Adding images to the album directly via "Add -> Upload Files" (top right corner) works as expected, but this option does not appear as long as the album is still empty. A possible temporary fix would be just omitting the special behavior for empty albums and always showing the "Add" menu which allows for direct upload?"

I have to select a random picture from my album, so the album isn't empty, then the option to upload directly to the album shows up.

@skranz0
Copy link

skranz0 commented Jan 14, 2025

I'm on Nextcloud 29.0.9 and for me the problem is reversed? I was able to upload images to the empty album but since then nothing happens when I add new images.
The upload dialogue opens, I choose an image, click upload, the dialogue closes and nothing happens. Neither does the new image appear in the album nor is it uploaded to the Photos directory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0. Needs triage Pending approval or rejection. This issue is pending approval. bug Something isn't working needs info Not enough information provided
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants