Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset file list on upload in FilesPicker #1782

Merged
merged 1 commit into from
May 12, 2023

Conversation

artonge
Copy link
Collaborator

@artonge artonge commented May 10, 2023

Fix #1396

Screencast.from.2023-05-11.12-06-59.webm

@artonge artonge enabled auto-merge May 10, 2023 11:49
@artonge artonge self-assigned this May 10, 2023
@artonge artonge added bug Something isn't working 3. to review Waiting for reviews javascript Javascript related ticket labels May 10, 2023
@artonge artonge requested a review from skjnldsv May 10, 2023 11:50
@artonge artonge added this to the Nextcloud 27 milestone May 10, 2023
@artonge artonge force-pushed the artonge/fix/refresh_file_list_on_upload branch from edb5994 to aac912b Compare May 10, 2023 11:51
@artonge
Copy link
Collaborator Author

artonge commented May 10, 2023

/backport to stable26

@artonge
Copy link
Collaborator Author

artonge commented May 10, 2023

/backport to stable25

@backportbot-nextcloud backportbot-nextcloud bot added the backport-request Pending backport by the backport-bot label May 10, 2023
@artonge artonge requested review from a team, susnux and nfebe and removed request for a team May 10, 2023 15:33
@skjnldsv
Copy link
Member

Does that means it will always flash end re-render the entire list? Could we find a middle ground and just append the new files?

@artonge artonge force-pushed the artonge/fix/refresh_file_list_on_upload branch from aac912b to 7ca16d5 Compare May 11, 2023 10:08
@artonge
Copy link
Collaborator Author

artonge commented May 11, 2023

Does that means it will always flash end re-render the entire list? Could we find a middle ground and just append the new files?

Updated, less flashy, not perfect, but I don't think we can do better.

Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge artonge force-pushed the artonge/fix/refresh_file_list_on_upload branch from 7ca16d5 to 25c33ac Compare May 11, 2023 13:07
@artonge artonge merged commit 2aa5818 into master May 12, 2023
@artonge artonge deleted the artonge/fix/refresh_file_list_on_upload branch May 12, 2023 08:45
@backportbot-nextcloud
Copy link

The backport to stable26 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable26
git pull origin/stable26

# Create the new backport branch
git checkout -b fix/foo-stable26

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable26

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@backportbot-nextcloud
Copy link

The backport to stable25 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable25
git pull origin/stable25

# Create the new backport branch
git checkout -b fix/foo-stable25

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable25

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews backport-request Pending backport by the backport-bot bug Something isn't working javascript Javascript related ticket
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Uploading files to an album does not work
2 participants