-
-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BITV] 9.1.4.11/4.4 - Note: The "Close" button of the modal dialog "New album" is not visually prominent. It would be better to place the button directly within the dialog instead of outside of it. (1) #2174
Comments
Vue component issue. My opinion: we should really get rid of those button outside the modal, and if we keep them add background to it or always force dark backdrop. |
I think we cannot get rid of it because the viewer uses it as well? |
So I would simply would adjust the modal in the photos app to use the close button inside the modal and/or should we force dark backdrop in the library? Also cc @nextcloud/designers |
I would say force dark backdrop if next prev or name is set |
I am wondering if we should by default show the WDYT @susnux @JuliaKirschenheuter @Pytal @ShGKme ? |
Yeah, I thought about it many times. Currently, many apps manually overwrite The simplest solution could be to add new props for it, but there are so many props already. But personally, I'd like to ideally have:
So we won't have super-component with a lot of props and flags, but also have something easy to use in apps. |
Thats why we have two components: NcModal for everything custom like the viewer. |
So thr solution would be to migrate the photos modals to ncdialog? |
Yeah, cool. I missed that dialogs are configurable enough to replace |
https://report.bitvtest.de/default-en/cbedb5ef-4815-4cba-a83d-995599c178c3.html#checkpoint-3dbfb7615a-v4-n4
The text was updated successfully, but these errors were encountered: