Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make modal mask dark if some icons are shown outside #4916

Merged
merged 2 commits into from
Dec 7, 2023

Conversation

szaimen
Copy link
Contributor

@szaimen szaimen commented Dec 5, 2023

Signed-off-by: Simon L <szaimen@e.mail.de>
@szaimen szaimen added enhancement New feature or request 3. to review Waiting for reviews design Design, UX, interface and interaction design accessibility Making sure we design for the widest range of people possible, including those who have disabilities labels Dec 5, 2023
@szaimen szaimen added this to the 8.4.0 milestone Dec 5, 2023
Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add a line to the docstring of the dark prop that it will be overridden with true if external buttons are used

Signed-off-by: Simon L <szaimen@e.mail.de>
@szaimen
Copy link
Contributor Author

szaimen commented Dec 7, 2023

Maybe add a line to the docstring of the dark prop that it will be overridden with true if external buttons are used

done

@szaimen szaimen merged commit ebc1e52 into master Dec 7, 2023
15 checks passed
@szaimen szaimen deleted the enh/noid/modal-mask-dark branch December 7, 2023 13:03
ShGKme pushed a commit that referenced this pull request Dec 11, 2023
ShGKme pushed a commit that referenced this pull request Dec 11, 2023
@ShGKme ShGKme mentioned this pull request Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews accessibility Making sure we design for the widest range of people possible, including those who have disabilities design Design, UX, interface and interaction design enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants