Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sidebar button on the Navigation #9

Closed
skjnldsv opened this issue Nov 28, 2019 · 0 comments · Fixed by #11
Closed

Add sidebar button on the Navigation #9

skjnldsv opened this issue Nov 28, 2019 · 0 comments · Fixed by #11
Assignees
@jakobroehrl
Labels
1. to develop Accepted and waiting to be taken care of enhancement New feature or request good first issue Good for newcomers high High priority
Milestone
1.0.0

Comments

@skjnldsv
Copy link
Member

skjnldsv commented Nov 28, 2019 •
edited
Loading

Right next to the folder name, show an icon to open the new sidebar

There will be tabs missing as some are not working without the files app (will bugfix after) but the sharing tab should work I think :)
The viewer also needs to be update to work with the new Sidebar https://github.com/nextcloud/viewer/blob/c76f79a4419a5488322a66afa334811b9a12bc55/src/views/Viewer.vue#L569

The new sidebar was implemented here nextcloud/server#15719
the new functions for the sidebar are:

  • OCA.Files.Sidebar.close()
  • OCA.Files.Sidebar.setActiveTab(tabId)
  • OCA.Files.Sidebar.open(path)
@skjnldsv skjnldsv added enhancement New feature or request good first issue Good for newcomers high High priority 1. to develop Accepted and waiting to be taken care of labels Nov 28, 2019
@skjnldsv skjnldsv added this to the 1.0.0 milestone Nov 28, 2019
@jakobroehrl jakobroehrl mentioned this issue Nov 28, 2019
Merged
@jakobroehrl jakobroehrl self-assigned this Nov 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jakobroehrl jakobroehrl

Labels
1. to develop Accepted and waiting to be taken care of enhancement New feature or request good first issue Good for newcomers high High priority
Projects
None yet
Milestone
1.0.0
Development

Successfully merging a pull request may close this issue.

Add sidebar button on the Navigation nextcloud/photos
2 participants
@skjnldsv @jakobroehrl