-
-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sidebar button on the Navigation #11
Conversation
@skjnldsv Could you look over this, please? |
It will need nextcloud/server#18213 |
Pulled 18213 into server |
what is your issue?
AH yes server is not compiled, let me fix |
probably an issue in the console? |
Sure: TypeError: OCA.Files.App.fileList._getIconUrl is not a function |
Should be fixed on server |
you don't have the sharing content? |
e1a263d
to
7dac8b5
Compare
7dac8b5
to
973aca8
Compare
ALl done, @jakobroehrl please review ;) |
/compile amend / |
973aca8
to
1de825a
Compare
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com> Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
1de825a
to
ea4f253
Compare
Signed-off-by: Jakob jakob.roehrl@web.de
fix #9
This is not working:
OCA.Files.Sidebar.open(this.filename)
Error in v-on handler: "TypeError: Cannot read property 'Sidebar' of undefined"